Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
You have a few options for how to use this issue:
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Using the patches
Using the merge request
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.ymlfile for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #5
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #8
v.dovhaliuk commentedA new patch has been provided since using MR as a patch is a security issue.
Comment #10
pfrenssenI did the remaining compatibility fixes, but it looks like this still needs more work. Some of the updates to the tests look like they might introduce new failures. I ran the tests and had a large number of warnings, errors and failures. A number of these probably are already happening in the main branch.
Comment #12
ethantI tested this MR on a Drupal 11.4.4 site (PHP 8.3.30), with payment 2.2.0 installed through composer-drupal-lenient and the MR applied as a patch. Install and enable are clean for payment, payment_form, and payment_reference, plugin discovery works, and payment method configuration entities load.
Two admin pages still returned 500 on current core:
- /admin/config/services/payment/method/configuration
- /admin/config/services/payment/status (when at least one config entity status exists)
Both throw RouteNotFoundException for entity.payment_method_configuration.canonical or entity.payment_status.canonical. Core 11.3.0 started adding an automatic View operation in EntityListBuilder::getDefaultOperations() whenever an entity type declares a canonical link template. Both entity types here declare canonical in their annotations, but the module never registers those routes, so rendering the operations column throws. Core 11.2 and earlier never generated that link, which is why earlier testing would not have hit it. This is likely also part of the functional test failures mentioned in #10.
I pushed a commit that registers entity.payment_status.canonical and entity.payment_method_configuration.canonical with the same paths, handlers, and access requirements as the existing edit_form routes, matching the paths the annotations already point at. The alternative would be dropping the canonical link templates from the two annotations; I went with additive routes since nothing changes for Drupal 9 and 10.
After that commit the admin sweep renders 200 throughout: payment hub, method plugin list, method configuration list, statuses overview, status add form, payment types, and the /admin/content/payment view.
Comment #15
berdirMerged, didn't run into any issues for now. Not willing to spend time on getting the tests green, they're not even enabled right now.