Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | clamav.2.0.2.rector.patch | 386 bytes | project update bot |
Issue fork clamav-3429235
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
klemendev commentedIs a stable release supporting D11 planned?
Comment #7
vladimirausSee CI report. More work required.
Comment #8
alex.skrypnyk@vladimiraus
I see you added CI that is now reporting issues that have been present in the module for a long time.
Is it possible to do the D11 upgrade as-is and fix those code standards violations in another issue?
I am currently using this module on D11 with the original patch and lenient plugin and functionality-wise it is working correctly.
`hook_file_validate()` was removed from D11 and the scanning stopped allowing files with viruses to be uploaded. Much more work required. Apologies for the noise.
Comment #9
vladimirausAll good. Thanks @alex.skrypnyk.
Comment #10
vladimirausThere is work happening in
hook_file_validate()fix in #3423615: Remove deprecated hook_file_validate() and implement Constraint plugins.Comment #11
vladimirausOnly dependency injections are left.
As there is work on refactoring is happening in 4.0.x, I won't be doing it here.
Comment #12
jannakha commentedhook_file_validate() will be replaced with event handler in this task
issue #3423615 was not implemented for this module
Comment #14
vladimiraus@smustgrave - thanks for your commit, but you changes do not bring full D11 compatibility e.g. `hook_file_validate()` was removed from D11.
Can you create separate issue for phpcs and issues for any other CI tasks?
Cheers 👍
Comment #15
vladimirausChanging branch for D11 support.
Comment #17
smustgrave commentedConfused on the game plan here.
1. Is a new branch starting for 10.3/11
2. In slack you mentioned the hold up was phpstan stuff
Comment #18
jannakha commentedComment #19
jannakha commented@smustgrave I think there is some confusion.
D11 compatibility is not fully implemented. File scanner is not working.
Please do phpcs separately once 2.1.0 release is done.
Comment #20
smustgrave commentedThanks but I’m good don’t know the direction this project is trying to go so will just wait for the D11 release. Thanks!
Comment #21
jannakha commentedTested on Drupal 11. File scanning is working with executable and not allowing to upload the file when execution is disabled.
Comment #23
vladimirausThanks @jannakha & @smustgrave.
That looks good.
Tested MR!15. Works as expected.
Merging and testing MR!12.
Comment #24
smustgrave commentedWoo! Last one for us for D11
Comment #25
vladimirausLast sanity check.
Comment #26
jannakha commentedworks as required.
Thank you for your contributions and support!
Hurray for D11
Comment #28
vladimirausCheers @everyone who was working on this issue. 🥂
Big kudos to DrevOps for sponsoring the release. 🥳
Committed! 🍰
Comment #29
klemendev commentedThank you for work on this and big thanks to the sponsors!
Comment #30
jannakha commented