Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#2 clamav.2.0.2.rector.patch386 bytesproject update bot

Issue fork clamav-3429235

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new386 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-120835

This patch was created using these packages:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.7
  3. palantirnet/drupal-rector: 0.20.1

klemendev’s picture

Issue summary: View changes

Is a stable release supporting D11 planned?

somersoft made their first commit to this issue’s fork.

vladimiraus changed the visibility of the branch 3429235-automated-drupal-11 to hidden.

vladimiraus’s picture

Status: Needs review » Needs work

See CI report. More work required.

alex.skrypnyk’s picture


@vladimiraus
I see you added CI that is now reporting issues that have been present in the module for a long time.
Is it possible to do the D11 upgrade as-is and fix those code standards violations in another issue?

I am currently using this module on D11 with the original patch and lenient plugin and functionality-wise it is working correctly.

`hook_file_validate()` was removed from D11 and the scanning stopped allowing files with viruses to be uploaded. Much more work required. Apologies for the noise.

vladimiraus’s picture

All good. Thanks @alex.skrypnyk.

vladimiraus’s picture

vladimiraus’s picture

Version: 2.0.2 » 2.0.x-dev
Status: Needs work » Needs review

Only dependency injections are left.

As there is work on refactoring is happening in 4.0.x, I won't be doing it here.

jannakha’s picture

Status: Needs review » Needs work

hook_file_validate() will be replaced with event handler in this task

issue #3423615 was not implemented for this module

smustgrave made their first commit to this issue’s fork.

vladimiraus’s picture

@smustgrave - thanks for your commit, but you changes do not bring full D11 compatibility e.g. `hook_file_validate()` was removed from D11.
Can you create separate issue for phpcs and issues for any other CI tasks?
Cheers 👍

vladimiraus’s picture

Version: 2.0.x-dev » 2.1.x-dev
Category: Task » Feature request

Changing branch for D11 support.

smustgrave’s picture

Confused on the game plan here.

1. Is a new branch starting for 10.3/11
2. In slack you mentioned the hold up was phpstan stuff

jannakha’s picture

jannakha’s picture

@smustgrave I think there is some confusion.
D11 compatibility is not fully implemented. File scanner is not working.
Please do phpcs separately once 2.1.0 release is done.

smustgrave’s picture

Thanks but I’m good don’t know the direction this project is trying to go so will just wait for the D11 release. Thanks!

jannakha’s picture

Status: Needs work » Needs review

Tested on Drupal 11. File scanning is working with executable and not allowing to upload the file when execution is disabled.

  • vladimiraus committed f0a409c4 on 2.1.x authored by jannakha
    Issue #3429235 by vladimiraus, jannakha, project update bot, smustgrave...
vladimiraus’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @jannakha & @smustgrave.
That looks good.
Tested MR!15. Works as expected.
Merging and testing MR!12.

smustgrave’s picture

Woo! Last one for us for D11

vladimiraus’s picture

Status: Reviewed & tested by the community » Needs review

Last sanity check.

  • phpcs should be separate issue
  • phpstan only contains dependency injection warning which should be another issue
jannakha’s picture

Status: Needs review » Reviewed & tested by the community

works as required.
Thank you for your contributions and support!
Hurray for D11

vladimiraus’s picture

Status: Reviewed & tested by the community » Fixed

Cheers @everyone who was working on this issue. 🥂
Big kudos to DrevOps for sponsoring the release. 🥳
Committed! 🍰

klemendev’s picture

Thank you for work on this and big thanks to the sponsors!

jannakha’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.