Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#13 coffee.1.x-dev.rector.patch1.32 KBproject update bot
#9 coffee.1.x-dev.rector.patch1.32 KBproject update bot
#9 interdiff-last-bot.6943612.txt319 bytesproject update bot
#7 coffee.1.x-dev.rector.patch1.74 KBproject update bot
#7 interdiff-last-bot.6911001.txt252 bytesproject update bot
#4 coffee.8.x-1.4.rector.patch1.32 KBproject update bot
#4 interdiff-last-bot.6909926.txt289 bytesproject update bot
#2 coffee.8.x-1.4.rector.patch991 bytesproject update bot

Issue fork coffee-3428399

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new coffee.8.x-1.4.rector.patch991 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-120024

This patch was created using these packages:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.7
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !13

project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6909926.txt289 bytes
new coffee.8.x-1.4.rector.patch1.32 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-120835

This patch was created using these packages:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.7
  3. palantirnet/drupal-rector: 0.20.1

gg24 made their first commit to this issue’s fork.

gg24’s picture

gg24 commented
Issue summary: View changes

Please review the PR. I have also fixed some coding in the same PR. Rest all looks to me in the PR.

project update bot’s picture

project update bot commented
Version: 8.x-1.4 » 8.x-1.x-dev
Issue summary: View changes
StatusFileSize
new interdiff-last-bot.6911001.txt252 bytes
new coffee.1.x-dev.rector.patch1.74 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-188138

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.2
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.2

Project Update Bot opened merge request !14

project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6943612.txt319 bytes
new coffee.1.x-dev.rector.patch1.32 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-188815

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.2
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.2

VladimirAus changed the visibility of the branch project-update-bot-only to hidden.

VladimirAus opened merge request !15

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes

Not sure about dropping support for 9.x

project update bot’s picture

project update bot commented
Issue summary: View changes
StatusFileSize
new coffee.1.x-dev.rector.patch1.32 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-244074

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.4
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.3
dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community 
$ git apply -v coffee.1.x-dev.rector.patch
Checking patch coffee.info.yml...
Checking patch tests/src/Functional/CoffeeTest.php...
Checking patch tests/src/Kernel/CoffeeCommandsTest.php...
Applied patch coffee.info.yml cleanly.
Applied patch tests/src/Functional/CoffeeTest.php cleanly.
Applied patch tests/src/Kernel/CoffeeCommandsTest.php cleanly.

Upgrade status says Coffee supported now. No flaws yet detected. Works as usual. +1 RTBC

kgaut’s picture

kgaut commented

+1 for RTBC thanks !

hswong3i’s picture

hswong3i commented

Apply this MR for D11 now with:

...
    "repositories": {
        "https://packages.drupal.org/8": {
            "canonical": false,
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        },
        "https://drupal.org/node/3428399": {
            "canonical": false,
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/coffee-3428399.git"
        },
    },
...
    "require": {
        "drupal/coffee": "dev-3428399-automated-drupal-11",
    }
...
robcarr’s picture

robcarr
Primary language English
Location Perthshire, Scotland
commented

Love this module. +1 for commit to DEV

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
Status: Reviewed & tested by the community » Needs work

GitLab is failing, though...? I should be able to take care of those.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
Status: Needs work » Needs review

The "upgrade status" CI job is still failing but I'm not really sure what, if anything, to do there. It feels like a job that should be allowed to fail, but that's not a call I feel qualified to make. :)

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs review » Reviewed & tested by the community

Awesome work +1 @phenaproxima - seems most issues are fixed now. Local test works and even a temporary previous issue (not reported yet here) of this branch not showing any content in the popup list is also wiped out. RTBC from here.

pameeela’s picture

pameeela commented

Just noting that we have had to remove Coffee from Drupal CMS until it is D11 compatible. #3473343: Switch our base to Drupal 11

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

@klausi @michaelmol Anything left to do blocking progress? I know too well how life and time is limited more than often, so let me know if you need co-maintainer support to get a D11 ready release. I am there to join, if required. Feel free to add me anytime.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented

We can simply remove the usage of upgrade_status as gitlab template default branch is D11 so there won't be a next major release in anytime soon.

cc: @dqd @phenaproxima

ankitv18’s picture

ankitv18 commented

Pipelines are passing ~~ we can plan a merge for this one. :)

abhinavk’s picture

abhinavk commented

MR!15 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

  • nebel54 committed ab117e0d on 8.x-2.x authored by vladimiraus 
    Issue #3428399 by phenaproxima, gg24, vladimiraus, ankitv18, hswong3i,...
nebel54’s picture

nebel54
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone! I have just created a new 2.x branch for future development and released the D11 compatible version 2.0.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Don't forget to credit the participants. 🤔

nebel54’s picture

nebel54
Primary language German
Location Vienna
commented
nebel54’s picture

nebel54
Primary language German
Location Vienna
commented

Sorry @vladimiraus - for some reason I thought the credit in the commit message triggers the credit system. Thanks for reporting it!