Problem/Motivation

Project url: https://www.drupal.org/project/field_group

This module has been previously vetted for Drupal 9 with the following snippet added to curated.json:

        {
            "package": "drupal/field_group",
            "constraint": "^3.3",
            "replaces": {
                "name": "field_group"
            },
            "install": [
                "field_group",
                "field_group_migrate"
            ],
            "vetted": true
        },

Steps to reproduce

n/a

Proposed resolution

Take snippet from D9 recommendation, update for Drupal 10 compatibility, add to D10 curated.json

Remaining tasks

  1. On a D7 site, install and set up field_group
  2. Add snippet from D9 recommendation into D10 curated.json (locally) - update version if there is a new one
  3. Generate new recommendations.json
  4. Use acli to generate a new D10 project based on this new recommendations.json file
  5. Test to see if recommendation still works
  6. If not, update recommendation snippet to D10 appropriate values and update recommendations.json by running make
  7. This module has test coverage in AM:A (here) which can be used to test as well after local. To do this, open a sibling MR against 1.9.x and alter AMA__10__RECOMMENDATIONS__VERSION in the .gitlab-ci.yml file (see this for an example)

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dan612 created an issue. See original summary.

dan612’s picture

Title: D10: Update recommendation for Field Group (drupal/bean) » D10: Update recommendation for Field Group (drupal/field_group)

dan612’s picture

StatusFileSize
new344.86 KB
new133.86 KB
new285.38 KB
new377.49 KB

Added a field group to ARTICLE content type in Drupal 7:
screenshot of field settings using field group in drupal 7
Here it is on the node add form:
screenshot of field group on node add form.
Then I ran AM:A and completed the migrations, which resulted in the following on D10:
screenshot of drupal 10 settings using field group
And the node add/edit form:
screenshot of node add/edit form using field groups in Drupal 10

So this seems to be working pretty well! Next, to create a sibling MR.

dan612’s picture

StatusFileSize
new46.7 KB

There is quite a bit of red that we need to debug in the CI...but I think the critical point of emphasis is here:
screenshot of passing pipelines job for field group migration test

dan612’s picture

Assigned: dan612 » Unassigned
Status: Active » Needs review

Wim Leers made their first commit to this issue’s fork.

wim leers’s picture

  • Wim Leers committed 08e48cfb on recommendations-10 authored by dan612
    Issue #3424949 by dan612: D10: Update recommendation for Field Group (...
wim leers’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.