Migrate well-prepared field group settings that do not change when the entity (form/view) displays are re-saved

1. +++ b/contrib/field_group_migrate/src/Plugin/migrate/source/d7/FieldGroup.php
   @@ -68,8 +120,20 @@ class FieldGroup extends DrupalSqlBase {
   +    // Add default settings.
   +    $context = $row->getSourceProperty('mode') === 'form' ? 'form' : 'view';
   +    $default_settings = $this->fieldGroupFormatterManager->prepareConfiguration($settings['format_type'], $context, $settings);
   +    $settings['format_settings'] += $default_settings['settings'];
   

   🤔 Is this what causes the field group configuration that gets added to the Entity(View|Form)Display to be restructured/reformatted to ensure that subsequent saves via the UI do not cause things to change anymore?

   IOW, is this what you meant by

   Migrate well-prepared field group settings […]

   ?

2. +++ b/contrib/field_group_migrate/src/Plugin/migrate/source/d7/FieldGroup.php
   @@ -68,8 +120,20 @@ class FieldGroup extends DrupalSqlBase {
   +    // Clean up obsolete settings.
   +    switch ($settings['format_type']) {
   +      case 'tabs':
   +        unset($settings['format_settings']['formatter']);
   +        break;
        }
   

   🤔 Why are these obsolete? An @see would be helpful here!

3. +++ b/contrib/field_group_migrate/tests/src/Functional/MigrateUiFieldGroupTest.php
   @@ -0,0 +1,201 @@
   +  /**
   +   * Modules to enable.
   +   *
   +   * @var array
   +   */
   

   {@inheritdoc}

   🤓

4. +++ b/contrib/field_group_migrate/tests/src/Functional/MigrateUiFieldGroupTest.php
   @@ -0,0 +1,201 @@
   +    $this->assertNodeArticleDefaultForm();
   +    $this->assertNodePageDefaultForm();
   +    $this->assertNodeArticleTeaserDisplay();
   +    $this->assertNodePageDefaultDisplay();
   +    $this->assertUserDefaultDisplay();
   +
   +    // Re-save every field group's configuration to ensure that the migrated
   +    // settings aren't changed.
   +    $this->drupalGet(Url::fromRoute('entity.entity_form_display.node.default', [
   +      'node_type' => 'article',
   +    ]));
   +    $page->findButton('group_article_htabs_group_settings_edit')->click();
   +    $page->findButton('Update')->click();
   +    $page->findButton('group_article_group_settings_edit')->click();
   +    $this->submitForm([], 'Save');
   +
   +    $this->drupalGet(Url::fromRoute('entity.entity_form_display.node.default', [
   +      'node_type' => 'page',
   +    ]));
   +    $page->findButton('group_page_group_settings_edit')->click();
   +    $page->findButton('Update')->click();
   +    $page->findButton('group_page_tab_group_settings_edit')->click();
   +    $this->submitForm([], 'Save');
   +
   +    $this->drupalGet(Url::fromRoute('entity.entity_view_display.node.view_mode', [
   +      'node_type' => 'article',
   +      'view_mode_name' => 'teaser',
   +    ]));
   +    $page->findButton('group_article_htabs_group_settings_edit')->click();
   +    $page->findButton('Update')->click();
   +    $page->findButton('group_article_group_settings_edit')->click();
   +    $this->submitForm([], 'Save');
   +
   +    $this->drupalGet(Url::fromRoute('entity.entity_view_display.node.default', [
   +      'node_type' => 'page',
   +    ]));
   +    $page->findButton('group_page_group_settings_edit')->click();
   +    $this->submitForm([], 'Save');
   +
   +    $this->drupalGet(Url::fromRoute('entity.entity_view_display.user.default'));
   +    $page->findButton('group_user_group_settings_edit')->click();
   +    $page->findButton('Update')->click();
   +    $page->findButton('group_user_child_group_settings_edit')->click();
   +    $page->findButton('Update')->click();
   +    $page->findButton('group_user_tab1_group_settings_edit')->click();
   +    $page->findButton('Update')->click();
   +    $page->findButton('group_user_tab2_group_settings_edit')->click();
   +    $this->submitForm([], 'Save');
   +
   +    // Re-test the migrated field group configurations.
   +    $this->assertNodeArticleDefaultForm();
   +    $this->assertNodePageDefaultForm();
   +    $this->assertNodeArticleTeaserDisplay();
   +    $this->assertNodePageDefaultDisplay();
   +    $this->assertUserDefaultDisplay();
   

   👍 Aha, so this first checks the configuration of multiple view displays and form displays post-migration, then navigates to the admin UI for each, resaves it through the UI, and verifies they do not get overwritten.

🚢

Everything seems to be ok. I had to re-apply the patch, just a quick check if tests are still ok:

@nils.destoop the tests are failing at #8 , setting to NW.

Checking kernel tests , functional test results with fixes.

Updated and making some values default to pass assertions.

Fixed coding standard errors.

Removed whitespaces.

fixed comments.

Fixing comments again.

Thx, this has been committed to dev