Problem/Motivation

Title describes everything.

CommentFileSizeAuthor
#2 field_group-derive_migrations_per_entity_type_and_bundle-3177724-2.patch4.25 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new field_group-derive_migrations_per_entity_type_and_bundle-3177724-2.patch4.25 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented 
+++ b/contrib/field_group_migrate/src/Plugin/migrate/D7FieldGroupDeriver.php
@@ -0,0 +1,77 @@
+        [
+          'entity_type' => $entity_type,
+          'bundle' => $bundle,
+        ] = $field_group_row->getSource();

This syntax does not work in PHP 7.0, and that's the reason this is failing.

Array destructuring was introduced in PHP 7.1.

Retesting with PHP 7.1. PHP 7.1 has not even received security updates anymore in the past year. The Field Group project should update its automated testing configuration.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

This patch looks great — I could only find one nitpicky problem:

+++ b/contrib/field_group_migrate/src/Plugin/migrate/D7FieldGroupDeriver.php
@@ -0,0 +1,77 @@
+ * Derivers Drupal 7 field group migrations per entity type and bundle.

s/Derivers/Derives/

… hardly a problem obviously 🤓

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

It IS a problem. But definitely better than my usual c/p leftovers :D

  • nils.destoop committed 2f49e14 on 8.x-3.x authored by huzooka 
    Issue #3177724 by huzooka, Wim Leers: Derive D7 field group migrations...
nils.destoop’s picture

nils.destoop commented
Status: Reviewed & tested by the community » Fixed

Thx for the patch. Committed it to dev and updated the typo ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.