Problem/Motivation

login_destination_toolbar_alter() set a 0 max age so it disables cache entirely for this page.

Steps to reproduce

Browse the site with an user that can see the admin toolbar.
The pages are not cached.

Proposed resolution

The comment says this was done to have the URL vary based on the current path.
Disabling the cache for this is overkill. Adding the url.path cache context would probably be enough.

Issue fork login_destination-3423891

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff opened merge request !19

prudloff’s picture

prudloff commented
Status: Active » Needs review

GaëlG made their first commit to this issue’s fork.

jrockowitz made their first commit to this issue’s fork.

arousseau’s picture

arousseau commented
Status: Needs review » Reviewed & tested by the community

The MR applies to 2.0-beta8.

I was able to verify that the "current" query parameter appended to the login link's url, still varies correctly on page change.

rsvelko closed merge request !19

  • 227d7a10 committed on 8.x-2.x 
    Issue #3423891 by prudloff, gaëlg, jrockowitz:...
rsvelko’s picture

rsvelko commented
Status: Reviewed & tested by the community » Fixed

MR would not rebase easily, so I applied it as patch and pushed to dev.
Enjoy.
Marking as Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

prudloff’s picture

prudloff commented

Is there a plan to publish a new release containing this fix?

rsvelko’s picture

rsvelko commented

@prudoff - yes of course!
Just released 8.x-2.0-beta10 and the latest commit/MR is included. Enjoy!