Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\Core\ImageToolkit\Annotation\ImageToolkitOperationplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3420992

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

kim.pepper made their first commit to this issue’s fork.

kim.pepper opened merge request !6623

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review

Created a MR.

mstrelan’s picture

mstrelan commented
Status: Needs review » Needs work
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs work » Needs review
mstrelan’s picture

mstrelan commented
Status: Needs review » Reviewed & tested by the community

This looks great. All ImageToolkitOperation plugins have been converted to use attributes. I think it's better having all the docs, even if some like label seem self-explanatory.

mstrelan’s picture

mstrelan commented
Status: Reviewed & tested by the community » Needs work

As per @larowlan I think we need to add public readonly ?string $deriver = NULL to the constructor params.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

#8 appears to be addressed restoring RTBC status.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Would be great to file rector issue for conversions

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 328bb474d7 to 11.x and 4eed1aa1dc to 10.3.x. Thanks!

Adding to https://www.drupal.org/node/3395575

  • alexpott committed 4eed1aa1 on 10.3.x 
    Issue #3420992 by kim.pepper, mstrelan, larowlan: Convert...

  • alexpott committed 328bb474 on 11.x 
    Issue #3420992 by kim.pepper, mstrelan, larowlan: Convert...

kim.pepper closed merge request !6623

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Closed MR

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.