Closed (fixed)
Project:
Coding Standards
Component:
Meeting
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
8 Dec 2023 at 05:51 UTC
Updated:
13 Feb 2024 at 22:39 UTC
Jump to comment: Most recent
Hello all, it’s time for the fortnightly coding standards meeting.
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all time zones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
➤ The transcript will include comments made during the 24 hours of the meeting. However, comments made after the 24 hours may not be in transcript.
Current ping list: @catch, @larowan, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all time zones.
| larowlan | Hi |
| urvashi_vora | Hello |
| Alex Skrypnyk | Hi |
| Arkener | :wave: |
| Kingdutch | :wave: |
| catch | :wave: |
| longwave | :wave: |
1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.
| quietone | Confirm next meeting date due to holidays |
2️⃣ Action items
2️⃣.1️⃣ Approve previous minutes
| quietone | There are 3 at 'Needs Review' |
| urvashi_vora | Approved and Fixed[#3406354] |
| urvashi_vora | Can someone please approve?#3402696: Coding Standards Meeting Tuesday 2023-11-21 2100 UTC |
| urvashi_vora | Granting credits are remaining, so in chaos whether to mark it as fixed or no?#3397055: Coding Standards Meeting Wednesday 2023-11-07 2100 UTC |
3️⃣ For final discussion today
3️⃣.1️⃣ #3303206: Define a standard for adding declare(strict_types=1)
| larowlan | :shipit: |
| quietone | Yes, a bit premature but it is marked fixed. |
| Jonathan1055 | The freindly text was fixed by @quietone, but accidentally got reverted by @pfrenssen but I have now un-reverted back to the correct change. I think the issue is fixed now :slightly_smiling_face: |
| Jonathan1055 | I mean, the text in the issue summary is fixed. The actual issue status says 'fixed' but the steps 8 and 9 are still showing as remaining tasks. |
| quietone | II went ahead and updated the remaining tasks and removed the tag. Hopefully, this is nothing left to do! |
3️⃣.2️⃣ #3295249: Allow multi-line function declarations
| larowlan | There wasn't any feedback from the blog post other than not requiring trailing commas which I think we have prior art and reasoning for |
| quietone | Agree. This looks good to go, as long as there are no objections in the next 24 hours. |
| quietone | I just updated the CR so that it only has the change. |
| larowlan | Thanks |
| Jonathan1055 | I replied back to Nigel Cunningham in comment 48 that he was too late (he kind of knew that anyway). But it did make me wonder what exactly we would accept as an 'objection'? We publish the blog post asking for feedback, but really we are not expecting any and do not want to get any at that stage? |
| larowlan | Good question |
| larowlan | I think we would welcome feedback on technical grounds or with research/data from other projects but not personal preferences as @Nij's seemed to be in this case |
| larowlan | The main reason for trailing commas is less lines changed when you add a new Param leading to less likelihood of merge conflicts |
| larowlan | Ha someone cared enough to have a whole domain to argue the case for them https://www.trailingcommas.com/ :face_with_monocle: |
4️⃣ RTBC issues
4️⃣.1️⃣ #3324368: Update CSS coding standards to include PostCSS and Drupal 10
| quietone | This was brought up at a committer meeting. The feedback was all supporting this change. |
| catch | Yep - I think we can just go ahead here? |
| Björn Brala (bbrala) | @mherchel from what i understand, documentation can be updated :slightly_smiling_face: |
| Björn Brala (bbrala) | so eh, yeah @catch, think we should go ahead :slightly_smiling_face: |
4️⃣.2️⃣ #3074131: Use null coalescing operator ?? instead of a ternary operator with an isset() condition
| quietone | I suggested a change to the proposed text here. |
| Arkener | Agree with the proposed change, also left a suggestion for a change in title |
5️⃣ Keep the next meeting date or skip?
| quietone | The next meeting scheduled for Tuesday, 2 January 2024 22:00, UTC |
| quietone | I am most likely not available. |
| urvashi_vora | I will be available, as in India we have holidays till 1st December only, but respecting all countries, we could skip this meeting, as we will be having next meeting in 15 days from 2nd of January. |
| larowlan | I can run this but we mightn't have a big turnout |
| Alex Skrypnyk | not available.can we please not have the meeting next time as it does not give the opportunity to comment on issues in a timely manner due to being on holiday and some decisions are made by a smaller group of people (edited) |
| quietone | The blog announced 2 issues for final discussion at this meeting. |
| larowlan | We can update the blog post |
| quietone | That a good option. |
| Björn Brala (bbrala) | i'll be available that week |
Participants:
quietone, urvashi_vora, larowlan, Jonathan1055, catch, Björn Brala (bbrala), Arkener, Alex Skrypnyk
Comments
Comment #2
quietone commentedThis issue was announced on 26 October 2023 but missed the following meetings #2961791: Update Help Text Standards Examples to Modify Heading Structure
Comment #8
quietone commentedComment #10
quietone commentedComment #11
urvashi_vora commentedLGTM. Moving to RTBC.
Comment #12
quietone commented@urvashi_vora, thanks