Problem/Motivation

Certain texts in the validation messages weren't wrapped in t() functions and as such are missing translations.

Proposed resolution

Wrap the strings in t() functions, so translations can be provided.

CommentFileSizeAuthor
#8 Screenshot from 2024-06-10 12-47-13.png166.73 KBsourav_paul
#8 Screenshot from 2024-06-10 12-26-09.png483.14 KBsourav_paul
#2 3399824-untranslatable-text-2.patch14.06 KBsiemen_hermans

Issue fork password_policy-3399824

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

siemen_hermans created an issue. See original summary.

siemen_hermans’s picture

siemen_hermans commented
StatusFileSize
new 3399824-untranslatable-text-2.patch14.06 KB

Providing a patch for version 4.0.x

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Version: 4.0.0 » 4.0.x-dev
Status: Active » Needs work

Thanks for the issue and patch.

There are formatting issues. Please run this against the Drupal code style checker.

Diwakar07 made their first commit to this issue’s fork.

Diwakar07 opened merge request !77

diwakar07’s picture

diwakar07 commented
Status: Needs work » Needs review

Added missing t() function and tested the file through phpcs.
Please review the MR.

mably’s picture

mably commented

Are you really sure that you need to translate strings here?

It works fine in french as is.

All strings are already available for translation.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Issue summary: View changes
StatusFileSize
new Screenshot from 2024-06-10 12-26-09.png483.14 KB
new Screenshot from 2024-06-10 12-47-13.png166.73 KB

@Diwakar07 I've checked the password policy translation in Spanish & french

Its working fine...

No need to add t() translation...

french translation :
1:
fr

2: Only local images are allowed.

Spanish translation:
es

UI translation settings SS:

Only local images are allowed.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Status: Needs review » Closed (works as designed)

Closing this ticket as it works as designed...