Postponed
Project:
Claro
Version:
3.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Oct 2023 at 12:11 UTC
Updated:
21 Sep 2026 at 15:17 UTC
Jump to comment: Most recent
Claro's settings have 1 property paths that are not yet validatable:
$ ./vendor/bin/drush config:inspect --filter-keys=claro.settings --detail --list-constraints --fields=key,validatability,constraints➜ 🤖 Analyzing…
----------------------------------------------------------- ------------- ------------------------------------------
Key Validatable Validation constraints
----------------------------------------------------------- ------------- ------------------------------------------
claro.settings 75% ValidKeys: '<infer>'
RequiredKeys: '<infer>'
claro.settings: Validatable ValidKeys: '<infer>'
RequiredKeys: '<infer>'
claro.settings:third_party_settings NOT ⚠️ @todo Add validation constraints here
claro.settings:third_party_settings.shortcut Validatable ValidKeys: '<infer>'
RequiredKeys: '<infer>'
claro.settings:third_party_settings.shortcut.module_link Validatable ↣ PrimitiveType: { }
----------------------------------------------------------- ------------- ------------------------------------------
11.x.composer require drupal/config_inspector — or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 or newer (which supports Drupal 11!)composer require drush/drushvendor/bin/drush config:inspect --filter-keys=olivero.settings --detail --list-constraintsAdd validation constraints to:
third_party_settingsThis requires looking at the existing code and admin UI (if any) to understand which values could be considered valid. Eventually this needs to be reviewed by the relevant subsystem maintainer.
For examples, search *.schema.yml files for the string constraints: 😊
Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.
third_party_settingsNone.
None.
More validation 🚀
None.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
borisson_The config should be updated at the source of the problem here, which is in shortcut.schema.yml
Comment #5
prashant.c1. Added
mappingforthird_party_settingsinclaro.schema.yml2. Executed
ddev drush config:inspect --filter-keys=claro.settings --detail --list-constraintsgave all keys validated.Please review.
Thanks!
Comment #6
borisson_Should be in shortcut schema, see #2.
Comment #7
prashant.cBut
shortcut.schema.ymlalready has this section:Could you please guide here?
Thanks
Comment #8
borisson_I looked into this, I see that olivero does this in the same way. I'm not sure how we can tell the third party settings to apply to this.
Since I'm not sure how to proceed here, I asked in slack: https://drupal.slack.com/archives/C2THUBAVA/p1702728107642189
Comment #9
borisson_Actually, can we fix this the same way as #3402885: Theme third party settings should only contain settings for modules that are enabled?
-- edit:
Wait, that issue bring is in line with the state we currently have in HEAD for claro. I don't understand this.
Comment #10
prashant.cokay then I guess, we can follow the same approach based on the conclusion in https://www.drupal.org/project/drupal/issues/3402885.
Comment #11
wim leersThis now needs the
FullyValidatableconstraint to be added toclaro.settings. See https://www.drupal.org/node/3404425.Comment #13
svendecabooterThis is postponed on #3416178: Add validation constraints to `type: theme_settings`, because (amongst other issues) the "favicon" property contains properties that are dependent on the value of "use_default".
Comment #14
svendecabooterComment #15
wim leers@svendecabooter in #13: Yep, you're right — thanks!
Comment #17
quietone commentedThe Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.
Comment #18
smustgrave commented