Problem/Motivation

This module says there is no other dependency than popperjs. Which is great. But also requires Ckeditor installed to work, which in my opinion is not really a requirement.

I checked the code, and there are several checks to see if ckeditor module is installed. There is no need to force installing it as a dependency via composer and the info file.

Also it would enable users that only want to display tooltips to use this module, even if there is no CKEditor 4/5 installed in the site.

Steps to reproduce

Attempt to install the module, it will force you to enable ckeditor.

Proposed resolution

Remove the ckeditor dependency from the info file, and remove the composer.json file as it is not required to download this package either.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#6 tooltip-ckeditor5-plugin-to-apply-on-packaging.patch70.89 KBajeet_kumar
#5 tooltip-3394050-4.patch674 bytesdahousecat
#3 3394050-3.patch342 bytesbalagan
#2 3394050-2.patch1007 bytesdagmar

Issue fork tooltip-3394050

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dagmar created an issue. See original summary.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Active » Needs review
StatusFileSize
new 3394050-2.patch1007 bytes
balagan’s picture

balagan commented
StatusFileSize
new 3394050-3.patch342 bytes

Reroll for 1.1.2.
(I lied, this is not a reroll, the composer.json modification is missing, so it still needs some work).

jaypan’s picture

jaypan
Location Victoria, BC
commented
Status: Needs review » Reviewed & tested by the community

I agree with removing the dependency on ckeditor. I have downloaded this patch and tested it locally and it works.

dahousecat’s picture

dahousecat commented
StatusFileSize
new tooltip-3394050-4.patch674 bytes

Patch 3 would not apply for me due to the "Information added by Drupal.org" bit so I've created a version with that it in.

ajeet_kumar’s picture

ajeet_kumar
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new tooltip-ckeditor5-plugin-to-apply-on-packaging.patch70.89 KB
florismoriceau’s picture

florismoriceau
he/him
Primary language French
Location Nantes
commented
Status: Needs review » Reviewed & tested by the community

Patch #5 from @dahousecat is working fine.

Patch #6 does not fix the actual issue. We don't want to have CKE5 instead. Just remove the CKE dependency.

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 opened merge request !7

bluegeek9’s picture

bluegeek9 commented

I made a MR.

baysaa’s picture

baysaa commented

Could we get a release please, this is blocking Drupal 11 installation and causing pains via composer because of the CKEditor dependence

baysaa’s picture

baysaa commented

If anyone else is struggling like me, looks like adding "drupal/ckeditor" to "extra.drupal-lenient.allowed-list" is the only way to install 1.1.2 and apply this patch on Drupal 11.

benjamin_dk’s picture

benjamin_dk commented

A release would be much appreciated - I am also struggling with the dependency on CKEditor.