Coding Standards Meeting Tuesday 2023-10-10 2100 UTC [#3391801]

Hello all, it’s time for the fortnightly coding standards meeting.

This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all time zones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Current ping list: @catch, @larowan, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all time zones.

Alex Skrypnyk	:wave:
larowlan	hi
smustgrave	Jumping in and out
Björn Brala (bbrala)	Hi
gapple	:wave:
catch	Hello
dww	Derek

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

larowlan	keen to explore the roster system for admin tasks
smustgrave	This may have already been answered. But what’s the rule of thumb for a rule that doesn’t have a phpcs check. Example @returns
Kingdutch	There is a project:module naming convention, but I don't think it's actually enforced anywhere and Drupal core mostly ignores it? Can we update tooling to enforce the format (and maybe even check the project name if there's a composer.json above the referenced submodule)? Having the format consistently applied can help automated tooling related to composer, which needs to know the actual drupal/project name.

2️⃣ Action items

2️⃣.1️⃣ Approve previous minutes

2️⃣.2️⃣ TBD

2️⃣.3️⃣ TBD

3️⃣ Set up a roster for the committee

larowlan	I propose we setup a google calendar for this, that's how the secteam manage it, mori adds a 'triage duty' entry for the person on duty's email address and they accept
larowlan	those entries are 2 weeks long
larowlan	in this case we'd just need specific ones e.g. Run meeting Collate meeting notes...
quietone	Another regular task is creating the Blog post. It is mostly boilerplate but it does need to be accurate.
quietone	I have access to post the blog post. Does anyone else?
Alex Skrypnyk	@quietone do you have a run sheet on how to conduct these meetings? I mean - is there a place where the steps on how to run these meetings is documented?
quietone	I have a template locally that I adjust as needed.
quietone	I've tried to make a shared calendar, https://calendar.google.com/calendar/u/0?cid=ODNkZjViOWIwY2Q0M2U3YjUwYWF...…]DUwODY3MjEyYjViNDM3ZmFjM0Bncm91cC5jYWxlbmRhci5nb29nbGUuY29t
Alex Skrypnyk	If I understood correctly - we are talking about delegating what you do here to others on roster. If so, I think it would be super-useful to have that on D.O. so that anyone could run these meetings here. Apologies if I misunderstood the intent. (edited)
Alex Skrypnyk	And I personally think that this format works really well :+1:
larowlan	I don't think I have access to post
quietone	Thanks. And yes, anyone here can facilitate a meeting. Like most skills, it helps to work with someone the first time.
larowlan	I wonder if we could draft some help from @Mori Sugimoto in setting up the calendar as he manages the secteam one
larowlan	looks like that shared calendar worked, I was able to add it
quietone	@Alex Skrypnyk, I am not sure where to document the meeting process. And I am not sure that it is needed, most groups just build on the previous meeting format.
quietone	Any help setting it up would be great!
larowlan	for running #bugsmash I have a note locally in my notes app, that I copy paste,but there's a more formal /structured agenda there
larowlan	I would suggest using a slack post to store a template but we could lose slack history/premium features at any time, we only got it during covid and the grace period expired years ago
Alex Skrypnyk	Maybe just these: `0️⃣ Who is here today? Com 1️⃣ Do you have suggested topics 2️⃣ Action items 2️⃣.1️⃣ Approve previous minutes 2️⃣.2️⃣ TBD 2️⃣.3️⃣ TBD...`
larowlan	yeah
Björn Brala (bbrala)	Document in issue queue with link to issue in pinned. Or do it the programmer way and make gist. Could also be a gitlab page. Think those work nowadays and that would also never expire. (edited)
Björn Brala (bbrala)	I have no access to google calendar on my work address. Any change you can add: bbrala@gmail.com, which is my private account.
dww	Thanks for setting up the calendar! Happy to be involved, whacky scheduling permitting. :sweat_smile:
quietone	@Björn Brala (bbrala), you should have access now. I hope!

4️⃣ What needs to be done to make a post about the process change and new members?

5️⃣ New template for CS issues, #3387167: Add an issue template for the Coding Standards project

quietone	Any further changes needed?
Björn Brala (bbrala)	Commented. I like the change to include subpages in the issue if applicable. Other than that it seems all good.
Jonathan1055	Sub-pages are included in the template. We have 1. {link to the documentation heading that is to change} with 'current text' and 'proposed text' then following it we have 2. Repeat the above for each page or sub-page that needs to be changed. Hopefully that is clear enough for people filling in the issue template to know what to do
dww	I’m happy, but I wrote most of it, so I don’t think I should RTBC.
Jonathan1055	I'm happy too, and in that case I will RTBC
Jonathan1055	:slightly_smiling_face: @Björn Brala (bbrala) has already done it.
Björn Brala (bbrala)	Sorry forgot to post back here
Jonathan1055	No problem. There's no reason you should. I could have looked at the issue before commenting above. :slightly_smiling_face:

6️⃣ Finalize the process, #3365085: Update the coding standards process on the project page

quietone	This looks like a few last minutes tweaks.
quietone	Made adjustments thanks to @Jonathan1055
quietone	Hopefully, there will be no more and this can be 'Fixed'.
Jonathan1055	I think it is done. Nice work @cmlara @Alex Skrypnyk @catch @dww and of course @quietone

7️⃣ RTBC issue to review, #3012906: Add Markdown to list of module documentation file types

quietone	I just read this one and commented with a new suggestion.
quietone	But I agree that these two sections of documentation should agree.
Alex Skrypnyk	I've commented as well and put back to Needs work. Not sure if this is a correct action - please let me know if I'm overstepping (still new to the process). Thanks
quietone	@Alex Skrypnyk No worries, we are all new to the process!

8️⃣ What is the rule of thumb for a rule that doesn’t have a phpcs check. Example @returns from @smustgrave

quietone	The change is still not Drupal coding standard and should not be RTBC'ed or committed.
quietone	But we also don't want to slow down a change that is in the early stages, whether it is tagged 'needs architectural review' or not.
catch	@smustgrave do you mean #2916306: Use "@return" instead of "@returns"?

Participants:

larowlan, quietone, Alex Skrypnyk, Björn Brala (bbrala), dww, Jonathan1055, catch