Closed (fixed)
Project:
Coding Standards
Component:
Meeting
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
14 Sep 2023 at 04:55 UTC
Updated:
6 Nov 2023 at 04:39 UTC
Jump to comment: Most recent
Hello all, it’s time for the fortnightly coding standards meeting.
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all timezones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Current ping list: @catch, @larowan, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.
| urvashi_vora | Hi :wave: |
| Alex Skrypnyk | hi all! |
| Björn Brala (bbrala) | Björn, bit swamped :slightly_smiling_face: |
| quietone | Hi. I've been experiencing a bit of burn out and thus haven't followed up on some things. |
| Björn Brala (bbrala) | Don't worry, self comes first. :heart: |
| catch | :wave: |
| larowlan | Hey |
1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.
| quietone | blog post for new process and team members |
| quietone | How to identify words that are to stay in dictionary.txt |
| quietone | Parsing this meeting to an d.o issue |
2️⃣ Action items
2️⃣.1️⃣ Approve previous minutes
| quietone | #3380936: Coding Standards Meeting 2023-08-01 2100 UTC |
| quietone | #3385527: Coding Standards Meeting 2023-09-12 |
| urvashi_vora | Fixed #3380936: Coding Standards Meeting 2023-08-01 2100 UTC |
| urvashi_vora | @quietone I previously reviewed this #3385527: Coding Standards Meeting 2023-09-12 Left a feedback, please check. It misses few details |
| urvashi_vora | If we add replies for the "7" point which are at present missing, then this issue mentioned below, seems good to be Fixed. #3385527: Coding Standards Meeting 2023-09-12 |
2️⃣.2️⃣ TBA
3️⃣ Fixed since last meeting
| quietone | #3305090: Should core use cspell or cSpell |
| quietone | #3048495: Fix Drupal.Semantics.FunctionTriggerError coding standard |
| quietone | I am glad the last one was committed. I was tired of re-rolling it. |
4️⃣Blog post for new process and test members
| quietone | Gábor suggested this and there is a google doc but I don't think we finished (edited) |
| urvashi_vora | Yes, I added a title for the blog, but still not sure, how to add the context. would need other members help. |
| quietone | Yea, I too have not followed on this. |
| quietone | Anyone here want to take the lead on this and get it ready to publish? |
| urvashi_vora | I would like to come forward, but I need some guidance |
| Jonathan1055 | The final changes from comment 50 on #3365085: Update the coding standards process on the project page need to be made to the actual project page. It was approved by @catch The issue summary html can be copied & pasted directly into the project page. |
5️⃣ Spelling. How to agree on words that are to stay in the dictionary?
| quietone | There are still many misspellings but I do think it would help to have a list (spreadsheet?) where we can sort out what is to be done with some words. |
| quietone | As in, it stays in the dictionary. |
| quietone | or an issue needs to be opened upstream |
| Björn Brala (bbrala) | I feel like I miss context here. :x |
| Björn Brala (bbrala) | Is this about misspellings in the dictorionary that is included in cspell? |
| quietone | Yes and no. There are words in the dictionary that are Drupalisms, some technical terms, and some names used in composer.json. Those need to stay. But there are not identified. |
| Björn Brala (bbrala) | It's kinda annoying that some files are included like composer.json |
| quietone | Related is that I made this issue to have a specific Drupal dictionary. But in their last review, alexpott doesn't like the idiea. #3328741: Add a dictionary for Drupal-specific words |
| Björn Brala (bbrala) | Also stuff like .gitlab-ci.yaml |
| Björn Brala (bbrala) | Can't we catergorize inside that txtfile? |
| quietone | In one of the issues I recall longwave suggested no spell checking composer.json. But there are comments in that file. |
| Björn Brala (bbrala) | Yeah bit checking package names is so silly heh |
| quietone | The dictionary is maintained alphabetically. I think it would be a nightmare to do anything else, especially since there are no comments. |
| Björn Brala (bbrala) | Ah no comments possible makes that hard |
| Björn Brala (bbrala) | Hmm |
| quietone | And there are words like 'denormalize' that are not considered valid spellings. We can change the comments to add a hyphen but there are methods named, 'denormalize'. |
| quietone | I think we need a big list to identifiy these so people don't waste time working on removing words that are 'too hard' to removed. (edited) |
| Björn Brala (bbrala) | I agree that could be a good base to work from. |
| Björn Brala (bbrala) | Even a list with words with amount of usages could help |
| Björn Brala (bbrala) | (at least the ones we define) |
| catch | "he reason being once we've fixed all the misspellings that are in dictionary.txt - what is the point of drupal-dictionary.txt?" maybe we could add it then remove it later? |
| catch | I'll post that on the issue. |
| quietone | Here is a spreadsheet that attempts to put the words into categories, https://docs.google.com/spreadsheets/d/1XSRD1D59BQOjellZuLMU1V-5vLVAEVrF... |
| urvashi_vora | Thanks for the list |
| Björn Brala (bbrala) | Cool |
| Björn Brala (bbrala) | Think I read somewhere that Google sheets can also spell check with a function. Could be helpfull to see if that agrees it's a real word :sweat_smile: |
| Björn Brala (bbrala) | Good list thanks |
| urvashi_vora | @Björn Brala (bbrala) yes we do have spell check in google sheets. |
| urvashi_vora | With the Spell check function, we can change, ignore or we can add the selected data to the dictionary. |
| Kingdutch | No comments? Cspell supports comments starting with a # |
| Kingdutch | There are comments in the Open Social CSpell dictionary :thinking_face: |
| Björn Brala (bbrala) | Then you could use a single file and group also :sweat_smile: |
| Kingdutch | Or comment alphabetically (which is what we currently do, but I expect we have more individual strings and Drupal has more groups) |
6️⃣ Meeting etiquette for the parsing of the minutes
| quietone | Many don't know but the meeting parser is simplistic. |
| quietone | It does not capture emojis. So, please use text. |
| quietone | If you make a longer comment with line breaks. The line break is removed and the minutes person has to hunt and fix them. So, please make multiple comments. (edited) |
| Björn Brala (bbrala) | Hmm |
| Björn Brala (bbrala) | It could perhaps get some love that tool :stuck_out_tongue_winking_eye: |
| quietone | Just edited my comment , s/loner/longer/ |
7️⃣ Anyone want to make the minutes?
8️⃣ Wrap up
| quietone | Thanks for chatting. Threads open for 24 hours. |
| urvashi_vora | Thank you @quietone for hosting the meeting. |
Comments
Comment #7
quietone commentedComment #8
quietone commentedComment #9
quietone commentedComment #10
urvashi_vora commented2️⃣.1️⃣ Seems missing.
Moving it to Needs Work.
Comment #11
urvashi_vora commentedComment #12
urvashi_vora commentedI have updated the issue summary with missing 2️⃣.1️⃣, please review.
Thanks
Comment #13
quietone commented@urvashi_vora, Thanks for keeping up on the minutes.
I reviewed the additions and I don't see them in the meeting of 2023-09-27. I then looked back to the previous one, 2023-09-12, and the conversation added in #11 was in that meeting. I see it in Slack and it is in those minutes, #3385527: Coding Standards Meeting 2023-09-12.
Comment #14
urvashi_vora commented@quietone, I have updated the minutes for 2️⃣.1️⃣ Please review.
Thanks
Comment #15
jonathan1055 commentedChanged plain https links into better formatting for d.o. using [# ]
Comment #16
urvashi_vora commentedLooks good. Marking it as 'Fixed'.