Hello all, it’s time for the fortnightly coding standards meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Usually happens fortnightly on Tuesday 2100 UTC. The meeting open for 24 hours to allow for all timezones.
➤ Is done on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

Alex Skrypnyk here :wave:
urvashi_vora Hii:wave:
Kingdutch Ello :wave:
catch Hello.:wave:
longwave :wave:
Björn Brala (bbrala) hi! :cheetah:

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

2️⃣ Action items

2️⃣.1️⃣ Approve previous minutes

quietone #3350954: Coding Standards Meeting 2023-03-28 2100 UTC
quietone #3370898: Coding Standards Meeting 2023-07-04 2100 UTC
quietone #3370899: Coding Standards Meeting 2023-07-18 2100 UTC
quietone So, for these all that needs to be done is compare the minutes with the minutes in the backscroll in this  channel. And check that the credit is correct.
quietone And of course, comment on what you did to review.
quietone If the minutes are accurate, it is fine to set the status to Fixed.
longwave i have reviewed and approved the three above issues
longwave in the last one, there were a number +1 reactions by users who did not otherwise comment; i have noted these in the summary comment i made as they imply support for the policy in question (edited)

2️⃣.2️⃣ Follow up work to do on #2707507: Always add trailing commas, for arrays and annotations (edited) 

4️⃣ Issues tagged "final discussion"

quietone These have been announced, https://www.drupal.org/about/core/blog/coding-standards-proposals-for-fi....
quietone Be ready to discuss them at the next meeting.

4️⃣.1️⃣ #3238192: Allow omitting @var for strictly typed class properties

4️⃣.2️⃣ #3324368: Update CSS coding standards to include PostCSS and Drupal 10

5️⃣ Issues tagged "Needs announcement for final discussion". These we need to decide if they are ready for a final announcment. (edited) 

5️⃣.1️⃣ #2464123: Remove the requirement that no blank line follow an inline comment (edited) 

Björn Brala (bbrala) www.drupal.org/project/coding_standards/issues/2464123
Björn Brala (bbrala) Read through the issue and argument, and agree that this would be good to do.Think this use-case was the proverbial drop that overflowed the bucket:
    $this->clickLink('Cancel');
    // @todo Uncomment the following line after Core issue is fixed. See
    // #2582295: Confirmation cancel links are incorrect if installed in a subdirectory.
    // $this->assertSession()->addressEquals($overview_url);

    // Go to the next page.
    $this->drupalGet($next_page);

So I'd say, yes for thi sone

5️⃣.2️⃣ #3074131: Use null coalescing operator ?? instead of a ternary operator with an isset() condition

quietone There is a sniff for this.
quietone But does this need a docs change?
borisson_ I don't think it needs a doc change, the sniff should be enough?
Björn Brala (bbrala) Thats why i was thinking, IF it is not mentioned in the docs right now.
Björn Brala (bbrala) Wouldn't mind if more is dus described through the coding style checks  and less though real pages, that would make the process a little  easier perhaps.
borisson_ I'm not sure I understand this ^, you mean less documentation pages?
Björn Brala (bbrala) yes
Björn Brala (bbrala) But that is mostly a feeling I have. And I have not checked this feeling against the current governance rules.
Björn Brala (bbrala) (and this is kinda out of scope of this thread xD)
borisson_ haha, it sure is :smile:I think I agree, but let's open a thread for it at this (or the next) meeting to discuss this more specifically?
Björn Brala (bbrala) Yeah lets do it at next
Björn Brala (bbrala) Setting a reminder for over 13 days lol
Björn Brala (bbrala) Summarizing; Don't think we need doc change, we can coder this up, and it makes sense to do, so lets announce.

5️⃣.3️⃣ #2961791: Update Help Text Standards Examples to Modify Heading Structure

quietone Perhaps for this one we double check in accessibility that this is still the recommendation?
quietone That is, before making an announcment.
catch If help topics take over from hook_help() will this still be relevant?
quietone Good point.
quietone Checking one help topic page it looks like it is using the preferred headers.
quietone Looking at the Help text standards docs now.
quietone There is a page for Help Topic Standards.
quietone Neither of those pages is in the 'Coding Standards' part of the wiki.
quietone The module overviews in core still have the wrong headers.
quietone If hook_help is staying then this still needs work.
quietone I wonder if there should be a page for the Help standard in the Coding Standards guide?
urvashi_vora It would be good if we can include it, else the reference itself.

6️⃣ Last minutes change! #2140961: Allow constructor methods to omit docblocks

quietone In this issue concerns about the scope were raised after it went through the final discussion phase.
quietone Read about it from this comment onward #2140961: Allow constructor methods to omit docblocks#comment-15166236
quietone The result is that the scope has been reduced from 'all magic methods' to just 'constructors'.
catch I think this will be fine, we only really wanted the change for constructors.
borisson_ Yes, I agree with this, the other ones are not used as heavily anyway. We can always create and discuss for the other ones later - I think __construct is the biggest painpoint for custom/contrib code as well so +1

7️⃣  Activity in core

quietone Thanks to @longwave several spelling issues have been committed. There are about 1300 words to 'fix'.
quietone And I think they need to be done by component. Something like all the caching words.
quietone And these two, which implement a phpcs rule, are RTBC. #2722647: [Meta] Fix Drupal.Commenting.FunctionComment.InvalidNoReturn

8️⃣  Share your opinions on this. This could be an easy fix. #3305090: Should core use cspell or cSpell

urvashi_vora IMHO, "cspell" seems good.
quietone
All settings are prefixed with cSpell: or spell-checker:.

The docs state the above but then the examples, on the same page use both cSpell and cspell.

catch I've always assumed it was the lowercase one.
quietone lower case is easier to type. That is a plus.
urvashi_vora Indeed
longwave +1 to cspell although not sure how we can enforce this
quietone Maybe this? https://cspell.org/docs/case-sensitive/#enable-case-sensitive-checking-b...
quietone But that would cause more problems.
longwave
$ grep -rq cSpell core && echo failed
failed

we could do a rudimentary check in commit-code-check.sh but that feels like a slippery slope and there should be a better way

longwave maybe we can just use flagWords in the config? not sure if that would work for the case sensitive version only though
quietone I tried flagwords and it didn't help.
quietone I added case sensitivity and while I didn't let it finish it wasn't as bad as I expected.

9️⃣ Wrap up.  The meeting is open for 24 hours, Please continue to chat in the threads. A transcript is posted, usually within 1 week.

quietone Oh. and add threads if you want to.

Comments

quietone created an issue. See original summary.

quietone credited catch.

quietone credited longwave.

quietone’s picture

quietone credited bbrala.

quietone’s picture

quietone’s picture

Status: Fixed » Needs review

Ready for review

quietone’s picture

Issue summary: View changes

Change a link to use the #1234: "Mark all as read" in forums. form

urvashi_vora’s picture

Status: Needs review » Reviewed & tested by the community

Everything seems good here, I have rechecked the conversation with slack.

urvashi_vora’s picture

Status: Reviewed & tested by the community » Fixed

Marking it as Fixed.

Thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.