Problem/Motivation

It's been 9 months or so since #3306450: Update Chrome container to use newer version. That issue updated DrupalCI containers to Chrome 106, but Chrome 115 is now out. In local testing, I've been noticing some test failures that started in 115 that were passing in 114. It would be good to be able to see (and fix) those on DrupalCI.

Proposed resolution

Update to Chrome 115 or higher, but do we have a process for staging an update like this, so that we can get core tests passing on it before fully switching to it?

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drupalci_environments-3377509

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

effulgentsia created an issue. See original summary.

justafish made their first commit to this issue’s fork.

justafish opened merge request !42

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented

How it will affect contrib and D7?

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3404082: Adopt (semver) versioning for DrupalCi images
fjgarlin’s picture

fjgarlin commented

Good question. D7 contrib modules (https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes...) AND D7 core (https://git.drupalcode.org/project/drupal/-/blob/7.x/.gitlab-ci/pipeline...) would use the updated version, and we don't know that that would provoke.

Can we do versions in the chromedriver images? https://git.drupalcode.org/project/drupalci_environments/-/tree/dev/webd...
Same as what we do with PHP or database images?

fjgarlin’s picture

fjgarlin commented

We can leave the one we have now drupalci/chromedriver:production as it is, and maybe create a new one drupalci/chromedriver-2024:production (or whichever name is best) to use for places where we want/need a newer one.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I think we should retag existing image too with version tag and CR can promote upgrade of latest version and if someone needs to use old version they can use :bc tag for example

fjgarlin’s picture

fjgarlin commented

Happy with that too. Anything that can make it retrieve new vs old is good.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Now it needs review and testing new image drupalci/chromedriver:dev before creating production image

I already created copy of previous production image as drupalci/webdriver-chromedriver:production-bc and drupalci/webdriver-chromedriver:production-106

I will pick the commit to build production

PS: after each build, manually or script should be updated to tag drupalci/chromedriver additionally to what CI doing
as it is used instead of drupalci/webdriver-chromedriver by Drupal core

$ docker tag drupalci/webdriver-chromedriver:dev drupalci/chromedriver:dev
$ docker push drupalci/chromedriver:dev
The push refers to repository [docker.io/drupalci/chromedriver]
28a4868ac1f2: Mounted from drupalci/webdriver-chromedriver 
ac2949c69757: Mounted from drupalci/webdriver-chromedriver 
dev: digest: sha256:13f72207bde04065dc889726ded3825f3e8fe6ae0af96c7fa8d79a117137edc3 size: 742
fjgarlin’s picture

fjgarlin commented

#3423154: Change chromedriver for the new one used by core. is testing the BC image (drupalci/webdriver-chromedriver:production-bc).
Everything seems to be working as expected: https://git.drupalcode.org/project/gitlab_templates/-/pipelines/123158 (the red light and the warnings are expected).

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3156947: Create a new buildcontainer

Latest version ATM is 123.0.6312.134 https://chromereleases.googleblog.com/

andypost’s picture

andypost
he/him
Primary language Russian
commented

Webdriver is the only update image now #3517217: CI: Using stale drupalci chromedriver image (`chromedriver` is stale, `webdriver-chromedriver` gets updates)

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3528703: Get rid of phantomjs in PHP images