Problem/Motivation

Discovered in #3306446: Update Nightwatch to 2.4.1. To get us to the latest version of nightwatch, we need to get to the latest version of selenium-webdriver .

That version currently supports Chrome 101 and up.

Our current Drupal CI image runs:
(Session info: headless chrome=98.0.4758.102) and fails all nightwatch tests (https://dispatcher.drupalci.org/job/drupal_patches/145537/console)

Steps to reproduce

Proposed resolution

I know the "fun" we had after the last update landed in #3208793: Update Chrome container to use newer version, but I think/fear it's time for another round and a Drupal CI image with Google Chrome 104 (maybe even 105, which seems to land very soon)

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented

Marked this a "Major", since it blocks #3306446: Update Nightwatch to 2.4.1 which is a "Major".

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3306446: Update Nightwatch to 2.4.1
andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 to upgrade but it should be different image (hope it will contain version string) so users of old image cat test new one

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

As far as I know there is only one drupalci/chromedriver image that is shared by all DrupalCI environments, so we also have to be careful here not to break older test runs.

I do wonder in the long term if we should ship the Dockerfile for this with Drupal core instead, so the version used by the tests can be updated by core developers in step with the JS dependencies.

hestenet’s picture

hestenet
He/Him
Location Portland, OR 🇺🇸
commented

We are revisiting what the right time is to update this, because as @longwave notes, it can disrupt tests to make this change, particularly for older configs.

I would certainly support finding a good way to empower core to manage when they update this.

hestenet’s picture

hestenet
He/Him
Location Portland, OR 🇺🇸
commented
Status: Active » Needs review

Chromedriver has been updated to the latest version as of Oct 6, 2022:
https://hub.docker.com/repository/docker/drupalci/chromedriver

Putting in 'Needs review' for a bit before marking fixed, pending seeing if anything blows up. :)

spokje’s picture

spokje
Primary language Dutch
commented

@hestenet Could you confirm the version of Chromedriver for people that don't have/need/want access to hub.docker.com?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thank you @hestenet.

Can confirm that the daily core tests ran overnight on the new chromedriver, and we have some known random fails in SQLite but everything else looks good:

04:22:06 ℹ Connected to chromedriver-jenkins-drupal8-core-regression-tests-68321 on port 9515 (236ms).
04:22:06   Using: chrome (106.0.5249.103) on LINUX.
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

@Spokje not sure why the URL above requires you to log in, the containers are public at https://hub.docker.com/r/drupalci/chromedriver

Although they don't tell you the version anyway - but as seen above this is Chrome 106.

spokje’s picture

spokje
Primary language Dutch
commented

@longwave: Sorry, I blame lack of caffeine...

hestenet’s picture

hestenet
He/Him
Location Portland, OR 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the reviews.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

effulgentsia’s picture

effulgentsia commented

It's been a while since this issue, so Chrome 106 is now quite outdated. Therefore, I opened #3377509: Update Chrome container to use newer version (115 or higher).