Problem/Motivation

As the development of SDC builds within Drupal core we intend to build new components that Prototype will provide by default. Currently there is a tabs component however it needs to be updated regarding functionality, changes in schema, and overall accessibility.

Proposed resolution

Revamp the current tab files to be overall more accessible and adhere to expected coding standards.

Issue fork prototype-3374467

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jldust created an issue. See original summary.

philip_stier made their first commit to this issue’s fork.

michaelablackham’s picture

michaelablackham commented

QA & Accessibility

  1. Must be based off of WAI-ARIA approved Pattern: https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-manual/
  2. Must use default :focus styles for keyboard focus
  3. tab to "tab widget", use arrow keys to navigate to the tab, "enter" or "space" keys to select the appropriate tab

philip_stier opened merge request !109

philip_stier’s picture

philip_stier commented

@jldust - I think this new Tabs component is ready for review!

jldust’s picture

jldust commented
Status: Active » Needs work

Please keep this named tabs, re-add the previous existing component and name it menu-tabs

pixelwhip made their first commit to this issue’s fork.

pixelwhip closed merge request !109

pixelwhip reopened merge request !109

philip_stier’s picture

philip_stier commented
Status: Needs work » Needs review

@pixelwhip and @jldust - I've updated the naming of tabs components into "tabs-content" and "menu-tabs". Ready for review again :)

philip_stier changed the visibility of the branch 3374467-component-tabs to hidden.

philip_stier changed the visibility of the branch 3374467- to hidden.

  • jldust committed dded5edc on 5.x authored by philip_stier 
    Issue #3374467 by philip_stier, jldust, pixelwhip, michaelablackham:...
jldust’s picture

jldust commented
Status: Needs review » Reviewed & tested by the community

This looks great, thank you! I've merged this in to be included in the next tagged release.

jldust’s picture

jldust commented
Status: Reviewed & tested by the community » Fixed
jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)