Problem/Motivation

node-sass ^7.01 is required in `radix/src/kits/default/package.json`.

As noted here `https://github.com/sass/node-sass` node-sass 7 does not support node versions > 17.

As a result the theme compilation must build the sass-binary on the fly, resulting in very slow theme compilation (This was adding 4 minutes to our CI process.)

Proposed resolution

Update the required node-sass version to 8.0+

OR since node-sass is deprecated move to node-dart instead.

Comments

genebobmiller created an issue. See original summary.

doxigo’s picture

doxigo commented
Version: 5.1.x-dev » 5.0.x-dev
Status: Active » Fixed

Changed to "5.0.x-dev" and pushed a fix there, also bumped the node version to v18.16.1 in nvmrc. thanks for bringing this up

the 5.1.x-dev is not ready at all and might change quite drastically, I suggest not using that branch for now

ckng’s picture

ckng
Primary language English
commented

@doxigo, instead of using a fixed version number in the `.nvmrc`, we want to use `lts/hydrogen` for v18.* or `lts/gallium` for v16.* instead.

doxigo’s picture

doxigo commented

@ckng, never used it like so, would it always be the latest LTS version if you go with lts/hydrogen? and I wonder how that would play out with nvmrc

ckng’s picture

ckng
Primary language English
commented

@doxigo, it won't force the latest version, but the related major LTS version on the local that fulfill the requirement. In this case, user are not forced to use a specific version, as long as it is the same LTS major version.

doxigo’s picture

doxigo commented

Perfect, updated to lts/hydrogen, thanks for the hint

genebobmiller’s picture

genebobmiller commented

Amazing, thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.