During my testing of the module, error
PHP Parse error: syntax error, unexpected identifier "LayoutParagraphsLayoutTempstor...", expecting variable in /app/web/modules/contrib/mercury_editor/modules/mercury_editor_templates/src/Controller/InsertTemplateController.php on line 34
appeared during cache clear. A quick look in that file revealed that there are readonly properties used, even though the composer.json file doesn't declare dependency on PHP 8.1 (I'm using 8.0).
It's possible that there are more instances of these issues. It looks like https://github.com/symfony/polyfill-php81 won't help here, so perhaps there should be some rector-based transpiling happening during the development process?
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
anybodyI think the module should just require PHP 8.1 - that's totally fine now.
Comment #3
mohd sahzad commentedComment #4
mohd sahzad commentedHi @milos.kroulik,
needs more steps for reproduce this issue : Undeclared dependency on PHP 8.1
Comment #7
justin2pin commentedDeclared PHP 8.1 as a dependency in the module's composer.json file.