Database exception: Unknown column 'base.' when using entity types without bundle

Rerolled patch #1 for branch 2.1.x.

Thanks for your work here people ♥️🙏

Is there a core or contrib entity type to use to reproduce this?

This way it should be easy to add a test, which I think we need here

I am working here.

I got issue as mentioned here. Created MR 107. It is working for me. Adding screenshots of before and after applying changes. Moving this to Needs review state as pipeline is green.

There are still no clear steps to reproduce this issue, and still no tests 🤓✌️

Oh there are steps here now, awesome!

That should make it trivial to write a test then!

I also hit this issue and confirmed the MR as-is (without tests) does in fact fix the bug.

I took a stab at adding a test using the core User entity, since it is the most obvious choice of a bundleless entity type and matches the reproduction steps in the issue summary.

The test itself is tightly scoped to just a Link field to the User entity, create a user, and assert that LinkExtractorBatch::getTotalEntitiesToProcess() no longer throws the SQL error and correctly returns 1.

I ran tests locally and confirmed without the codefix the fatal error is triggered. I then ran the test again with the code fix and the test passes.

$ ddev phpunit tests/src/Kernel/LinkcheckerBundlelessEntityBatchTest.php
PHPUnit 11.5.55 by Sebastian Bergmann and contributors.
Runtime:       PHP 8.3.27
.                                                                   1 / 1 (100%)
Time: 00:03.781, Memory: 6.00 MB
OK, but there were issues!
Tests: 1, Assertions: 5, PHPUnit Deprecations: 2.

without fix:

ddev phpunit tests/src/Kernel/LinkcheckerBundlelessEntityBatchTest.php
PHPUnit 11.5.55 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.27

E                                                                   1 / 1 (100%)

Time: 00:06.754, Memory: 6.00 MB

There was 1 error:

1) Drupal\Tests\linkchecker\Kernel\LinkcheckerBundlelessEntityBatchTest::testGetTotalEntitiesToProcessForUserLinkField
Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'base.' in 'WHERE': SELECT COUNT(*) AS "expression"
FROM
(SELECT 1 AS "expression"
FROM
"test45522144users" "base"
WHERE "base"."" = :db_condition_placeholder_0) "subquery"; Array
(
    [:db_condition_placeholder_0] => user
)


/var/www/html/web/core/modules/mysql/src/Driver/Database/mysql/ExceptionHandler.php:96
/var/www/html/web/core/modules/mysql/src/Driver/Database/mysql/ExceptionHandler.php:26
/var/www/html/web/core/lib/Drupal/Core/Database/Connection.php:669
/var/www/html/web/core/lib/Drupal/Core/Database/Query/Select.php:521
/var/www/html/src/LinkExtractorBatch.php:173
/var/www/html/tests/src/Kernel/LinkcheckerBundlelessEntityBatchTest.php:82

Caused by
PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'base.' in 'WHERE'

/var/www/html/web/core/lib/Drupal/Core/Database/Statement/PdoTrait.php:109
/var/www/html/web/core/lib/Drupal/Core/Database/StatementWrapperIterator.php:89

However, both locally, and now on the CI pipeline, I see 10+ unrelated test failures when running all tests (as opposed to just the single new test I initially ran).

This MR branch is somewhat behind the latest 2.1.x branch, so I decided to see what would happen merging latest 2.1.x into my working copy of the MR branch and sadly, I still see the same failures. These failures are fundamentally unrelated to this issue, and they would affect ANY MR in the issue queue, and therefore this needs a follow-up issue.

I can safely remove the "Needs tests" tag now, and putting into NR, in case a maintainer might want to merge in spite of the unrelated test failures.

I fixed the unrelated CI failures in a separate issue, that I hope can get reviewed and merged so we can see tests working here too. Thanks!

#3582328: Fix broken tests blocking CI pipeline success