Problem/Motivation

Antibot third party hooks provide a setting to protect each individual webform, or even one setting to protect them all, in which case, the individual webform setting would be disabled.

However Antibot module provides an easier way to protect all webforms at once, using its UI settings, where you can specify the form IDs that should be protected, using wildcards. So there you can add webform_submission*, and that would protect all webforms.

We ran into confusion when we had that setting in Antibot, and we could still enable or disable the antibot third party checkbox in each webform. We had to do some testing enabling and disabling to figure out what would be the behavior and prevalence, noticing that no matter what we do in the webform configuration, the antibot module setting is already protecting all webforms.

Proposed resolution

To avoid this confusion it would be nicer to improve the antibot's third party UI in the webform configuration, so it webforms are already protected with webform_submission* by antibot module configuration, we would disable the checkbox (with value 1 as protected) in the third party settings of each webform and all webforms settings.

CommentFileSizeAuthor
#7 3367897-7.patch1.78 KBjrockowitz
#6 3367897-6.patch1.78 KBjrockowitz

Issue fork webform-3367897

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

juanolalla created an issue. See original summary.

juanolalla’s picture

Status: Active » Needs review

Opened a merge request implementing proposed solution.

jrockowitz’s picture

I am fine with the suggestion, but the same tweak should be made to similar SPAM settings including Honeypot.

jrockowitz’s picture

I see that you are trying to detect if antibot is enabled via /admin/config/user-interface/antibot.

jrockowitz’s picture

StatusFileSize
new1.78 KB

If someone has enabled antibot via /admin/config/user-interface/antibot, there is no need to display the antibot webform specific configuration.

Please review the attached patch.

jrockowitz’s picture

StatusFileSize
new1.78 KB

Fixing dump typos

juanolalla’s picture

Assigned: juanolalla » Unassigned
Status: Needs review » Reviewed & tested by the community

I like your solution, thank you very much. It works as expected.

  • jrockowitz authored a146bd55 on 6.1.x
    Issue #3367897 by juanolalla, jrockowitz: Antibot checkbox is confusing...

  • jrockowitz authored a146bd55 on 6.x
    Issue #3367897 by juanolalla, jrockowitz: Antibot checkbox is confusing...

  • jrockowitz authored a146bd55 on 6.2.x
    Issue #3367897 by juanolalla, jrockowitz: Antibot checkbox is confusing...
jrockowitz’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.