Problem/Motivation

Upload tab appears on node results page even if user doesn't have the "update any submission" permission.

Proposed resolution

Add the same requirement that we have on the non-node upload route:

_entity_access: 'webform.submission_update_any'

That should give something like:

entity.node.webform_submission_export_import.results_import:
  path: '/node/{node}/webform/results/upload'
  defaults:
    _form: '\Drupal\webform_submission_export_import\Form\WebformSubmissionExportImportUploadForm'
    _title_callback: '\Drupal\Core\Entity\Controller\EntityController::title'
    operation: webform_submission_view
    entity_access: 'webform.submission_view_any'
  options:
    parameters:
      node:
        type: 'entity:node'
  requirements:
    _entity_access: 'webform.submission_update_any'
    _custom_access: '\Drupal\webform_node\Access\WebformNodeAccess::checkWebformResultsAccess'

Issue fork webform-3366265

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mably created an issue. See original summary.

cilefen’s picture

Version: 6.1.4 » 6.2.x-dev
Category: Support request » Bug report
mably’s picture

jrockowitz made their first commit to this issue’s fork.

jrockowitz’s picture

jrockowitz’s picture

Status: Active » Needs review

jrockowitz’s picture

Status: Needs review » Fixed

  • jrockowitz committed 30728e33 on 6.2.x
    Issue #3366265 by mably, cilefen: Missing requirement for node specific...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.