CommentFileSizeAuthor
#4 after_2.png29.48 KBtanuja bohra
#4 after_1.png24.12 KBtanuja bohra
#4 after.png36.24 KBtanuja bohra
#3 cleanup-settings-page-3363431-3.patch6.99 KBchris matthews
#2 cleanup-settings-page-3363431-2.patch5.89 KBchris matthews

Issue fork block_class-3363431

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chris Matthews created an issue. See original summary.

chris matthews’s picture

chris matthews commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new cleanup-settings-page-3363431-2.patch5.89 KB
chris matthews’s picture

chris matthews commented
Issue summary: View changes
StatusFileSize
new cleanup-settings-page-3363431-3.patch6.99 KB
tanuja bohra’s picture

tanuja bohra commented
Issue summary: View changes
StatusFileSize
new after.png36.24 KB
new after_1.png24.12 KB
new after_2.png29.48 KB

Verified the "cleanup-settings-page-3363431-3.patch" for setting page. See the screenshots for reference. Can be move to RTBC++.

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

Great job, thanks

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

Has this been merged? There is nothing in the issue here indicating this.

dydave made their first commit to this issue’s fork.

dydave opened merge request !69

  • dydave committed ec2fb0e1 on 4.0.x 
    Issue #3363431 by chris matthews, dydave: Cleanup/standardize wording on...
dydave’s picture

dydave commented
Version: 2.0.x-dev » 4.0.x-dev
Status: Reviewed & tested by the community » Fixed

Sorry for the late reply on this task and thank you very much Chris (@chris matthews) for the wording improvements! 🙏

Just rolled in the patch from #3 into MR !69.

Since these changes had already been reviewed, tested and pending for a very long time, I went ahead and merged them above at #9 without further delay 😅

We have already started cleaning up the Project page, but more documentation work will probably be needed to better describe the various configuration options.

While working on the fields, I also found the use of certain fields could maybe seem quite limited, for example:
The maximum length fields (CSS classes or attributes), do we really need these kinds of settings?

Each feature added to the module adds an overhead on documentation, testing and maintenance... all that adding up, becomes non negligeable at some point...
It feels the module currently has too many configuration options, or they should perhaps be broken down into smaller pieces/sub-modules or organized differently.

In any case, for the time being this issue was focused at improving the wording of existing fields.
Any changes to the form settings and configuration of the module would have to be addressed in a separate issue.

There is still quite a lot of work needed to stabilize the 4.x branch...

Marking issue as Fixed, for now.

Feel free to let us know if you would have any questions or concerns on any aspects of the latest code changes or the module in general, we would surely be glad to hear your feedback. 😊
Thanks in advance!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.