Problem/Motivation

PHP deprecation notice:

Exception: Deprecated function: Creation of dynamic property Drupal\facets\Result\Result::$transliterateDisplayValue is deprecated
Drupal\facets\Plugin\facets\processor\DisplayValueWidgetOrderProcessor->sortResults()() (Line: 72)
CommentFileSizeAuthor
#30 3360426-30.patch7.41 KBmarios anagnostopoulos
#28 facets-php_compatibility_fixes-3360426.patch7.84 KBethomas08
#25 3360426-php8.2_compatibility-25.patch8.85 KBherved
#23 3360426-php8.2_compatibility_v2-23.patch7.34 KBcarolpettirossi
#14 3360426-creation-of-dynamic-properties-deprecated.patch1.38 KBjorisclaes

Issue fork facets-3360426

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rajeshreeputra created an issue. See original summary.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Issue summary: View changes
Status: Active » Closed (works as designed)
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Issue summary: View changes
Status: Closed (works as designed) » Active
ankitv18’s picture

ankitv18 commented
Assigned: Unassigned » ankitv18

ankitv18 opened merge request !141

benabaird made their first commit to this issue’s fork.

benabaird opened merge request !143

benabaird’s picture

benabaird commented

I've created a branch that addresses all dynamic property issues on PHP 8.2 for the 3.0 branch in a more robust manner. Instead of adding the missing property to the Result class I've added a generic storage property that can be accessed through get/set methods. This fixes the display value order processor, as well as opens up the ability for other custom processors to save arbitrary data on the result.

benabaird’s picture

benabaird commented

Sorry for the spam. Fixed the failing sort test. The tests that don't pass are not related to these changes.

benabaird’s picture

benabaird commented
Status: Active » Needs review
mvonfrie’s picture

mvonfrie commented

For me MR 143 works.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Closed #3336646: PHP 8.2 compatibility for the 2.0.x branch and #3340211: PHP 8.2 compatibility as duplicates.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

I can't RTBC this because I made the last changes. But for the bits I didn't work on, I can give a whole hearted +1. The number of test failures are also the same on HEAD, so I think this is ready. LGTM.

jorisclaes’s picture

jorisclaes commented
StatusFileSize
new 3360426-creation-of-dynamic-properties-deprecated.patch1.38 KB

I found some deprications:

Deprecated function: Creation of dynamic property

see the patch for inspiration

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work

#14 needs to incorporated into the MR please.

Liam Morland made their first commit to this issue’s fork.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review

I have added #14 to the merge request.

It would be helpful to add a PHP 8.2 automated testing configuration.

This merge request is changing a lot more than is needed to fix the "Creation of dynamic property" message. To just fix that, all that is needed is the fix in #3336646: PHP 8.2 compatibility for the 2.0.x branch.

mkalkbrenner made their first commit to this issue’s fork.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Fixed
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Nothing has been merged.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

Obviously the "merge train" didn't work. I merged manually now,

carolpettirossi’s picture

carolpettirossi commented
StatusFileSize
new 3360426-php8.2_compatibility_v2-23.patch7.34 KB

Here's a patch for the version 2.x of facets.
In our case, we can't upgrade to 3.x as we are using the facets_form module that is locked on 2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

herved’s picture

herved commented
StatusFileSize
new 3360426-php8.2_compatibility-25.patch8.85 KB

Static patch from MR 143, if anyone else needs it.

PS: Is there a plan for a 3.x-beta2 release yet?

marios anagnostopoulos’s picture

marios anagnostopoulos commented

Sorry for posting after this was closed.

Has this not been merged to 2.x, Or am I doing something wrong?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This was merged only in to branch 3.0.x. The 2.0.x branch was fixed in #3336646: PHP 8.2 compatibility for the 2.0.x branch; this fixed shipped in version 2.0.7.

ethomas08’s picture

ethomas08 commented
StatusFileSize
new facets-php_compatibility_fixes-3360426.patch7.84 KB

Re-rolled patch for 3.0.0-beta1 release because my team cannot use the more recent releases due to breaking changes.

nick hope’s picture

nick hope commented
Related issues: +#3406085: PHP 8.2 - Creation of dynamic properties is deprecated
marios anagnostopoulos’s picture

marios anagnostopoulos commented
StatusFileSize
new 3360426-30.patch7.41 KB

For everyone using 2.0.7

ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned