Problem/Motivation

The variable documentation is wrong in src/Service/BlockClassHelperService.php
I also suggest to change the variable name to $blockEntityStorage

  /**
   * The block entity.
   *
   * @var useDrupal\block\Entity\Block
   */
  protected $blockEntity;

Change to:

  /**
   * The block entity.
   *
   * @var \Drupal\Core\Entity\EntityStorageInterface
   */
  protected $blockEntityStorage;
CommentFileSizeAuthor
#5 3356444.png69.18 KBhmendes

Issue fork block_class-3356444

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paulocs created an issue. See original summary.

paulocs opened merge request !16

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Active » Needs review
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Assigned: paulocs » Unassigned
hmendes’s picture

hmendes commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3356444.png69.18 KB

Agree with the new name, and thanks for the fix on the doc block.
Uploaded a file to show the expected type of the return of entityTypeManager->getStorage().
Moving to RTBC.

chris matthews’s picture

chris matthews commented
Parent issue: » #3363340: Plan for 2.0.12 Release of Block Class

dydave closed merge request !16

dydave’s picture

dydave commented
Status: Reviewed & tested by the community » Closed (outdated)

This was addressed more recently in #3276398: Autocomplete widget not working as expected with merge request MR !67, where the pieces of code reported in the issue summary and in the merge request, have been removed from the file in more recent versions, see:
https://git.drupalcode.org/project/block_class/-/merge_requests/67/diffs...

Marking issue as Closed (outdated), for now, since these changes are not based on the most recent versions of the module.

Thanks again very much for the great work on this issue!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.