Problem/Motivation

https://git.drupalcode.org/project/geocoder/-/blob/8.x-4.x/src/Configura...

Parameter $http_adapter has typehint with deprecated interface Http\Client\HttpClient: since version 2.4, use Psr\Http\Client\ClientInterface instead; see https://www.php-fig.org/psr/psr-18/

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#14 Screenshot 2023-04-27 at 12.01.13 PM.png76.02 KBrajeshreeputra
#14 Screenshot 2023-04-27 at 12.01.29 PM.png54.4 KBrajeshreeputra

Issue fork geocoder-3355990

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Pasqualle created an issue. See original summary.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Unassigned » akshaydalvi212

I will work on this issue.

akshaydalvi212 opened merge request !22

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Status: Active » Needs review

I had replace the depreciated code for HTTPClient and also solve some coding issues with the branch.
kindly review the MR.

itamair made their first commit to this issue’s fork.

itamair’s picture

itamair commented
Title: HttpClient is deprecated » Http\Client\HttpClient is deprecated: use Psr\Http\Client\ClientInterface instead

  • itamair committed 15685b09 on 8.x-4.x 
    Issue #3355990 by akshaydalvi212, itamair, Pasqualle: Http\Client\...

  • itamair committed b0560eda on 8.x-3.x 
    Issue #3355990 by akshaydalvi212, itamair, Pasqualle: Http\Client\...

  • itamair committed 209e723e on 8.x-3.x 
    Issue #3355990 by akshaydalvi212: HttpClient is deprecated
itamair’s picture

itamair commented
Status: Needs review » Fixed

Thanks a lot. This was committed into the 8.x-4.x-dev branch, is going to be part of next Geocoder release

itamair closed merge request !22

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

With this changes now unable to install site with Drupal 10.0.7 and geocoder 4.6.

Error: Cannot instantiate interface Psr\Http\Client\ClientInterface in Drupal\Component\DependencyInjection\Container->createService() (line 259 of /Applications/MAMP/htdocs/acquia_cms/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php).

created another issue: 3356777

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Related issues: +#3356777: geocoderProvider googlemaps not working with 4.6
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
StatusFileSize
new Screenshot 2023-04-27 at 12.01.29 PM.png54.4 KB
new Screenshot 2023-04-27 at 12.01.13 PM.png76.02 KB

Please see attached screenshots

itamair’s picture

itamair commented
Status: Fixed » Needs work

Nice catch @Rajeshreeputra ... super thanks for this. Reopening this then.

vishalkhode made their first commit to this issue’s fork.

vishalkhode opened merge request !24

  • itamair committed 2309c80e on 8.x-3.x 
    Rollback of regressive fixes to Issue #3355990 by akshaydalvi212,...

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Assigned: Unassigned » ankitv18
itamair’s picture

itamair commented

I was too quick (and confident) with the initial fixes / contributions to this issue (that also affected the 3.x branch).
Please provide a full QA and Testing of what is being done here, so that I could perform mine one, being confident this properly marked as RTBC ...
This has become a super adopted module, so that any critical regression introduced would reflect in a big mess, coming from everywhere.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

To avoid these type of issue in future lets add testcase coverage in separate ticket.

  • itamair committed a860b4d8 on 8.x-4.x 
    Issue #3355990 by itamair, Rajeshreeputra, akshaydalvi212, ankitv18,...
itamair’s picture

itamair commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

itamair closed merge request !24