Problem/Motivation

FILE: /maxlength/tests/src/FunctionalJavascript/MaxLengthJavascriptTest.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
 80 | WARNING | Line exceeds 80 characters; contains 88 characters
---------------------------------------------------------------------------------------------------------------

FILE: /maxlength/tests/src/FunctionalJavascript/MaxLengthCkeditorTest.php
---------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------
   6 | ERROR   | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
 138 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 242 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 396 | ERROR   | [ ] Protected method name "MaxLengthCkeditorTest::getCKEditor4" is not in lowerCamel format
---------------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml maxlength

Proposed resolution

Fix the errors and warnings.

CommentFileSizeAuthor
#5 after-patch.png784.17 KBsourabhjain
#5 before-patch.png206.19 KBsourabhjain

Issue fork maxlength-3355530

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Binoli Lalani created an issue. See original summary.

Binoli Lalani opened merge request !32

binoli lalani’s picture

binoli lalani commented
Assigned: binoli lalani » Unassigned
Status: Active » Needs review

Hello,

I have fixed PHPCS errors and warnings. Please review MR.

Thank you!

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: Unassigned » sourabhjain

Let me review it.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: sourabhjain » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before-patch.png206.19 KB
new after-patch.png784.17 KB

I have reviewed the changes and its looks fine to me. Attaching Screenshots for reference.
Moving to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 2.1.1 » 2.1.x-dev
Priority: Normal » Minor
hipp2bsquare’s picture

hipp2bsquare commented
Assigned: Unassigned » joevagyok

I've confirmed the patch resolves the coding standards issues reported in phpcs, and visually reviewed the changes as well. This seems good to me, but cedewey and I would like for joevagyok to give it a final review prior to merging as the testing expert among the maintainers.

joevagyok made their first commit to this issue’s fork.

joevagyok’s picture

joevagyok commented
Status: Reviewed & tested by the community » Fixed
joevagyok’s picture

joevagyok commented

Thank you for the work on this!

joevagyok’s picture

joevagyok commented
Assigned: joevagyok » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.