Hook help for block content module is out of date after new permissions

created a MR, as per the new administer block content permission, pls review, suggestions are welcomed.thanks

Changes look good to have suggestions on if "manage" can be replaced by "configure" in the sentence just to be more specific and also being used inside the block layout page "The Custom Block module allows you to create, manage and delete custom block types and content-containing blocks."

These don't appear to be the suggestions @larowlan was looking for.

New permissions were added but they were not mentioned in the MR.

We definitely need to describe each new permission that was added. I would suggest adding a bulleted list with each new permission and a description of what it does. Note that the permissions are now per block type, so that should also be clearly described.

re #9 i am not sure if it would be necessary to describe each new permission on the help page. those help pages are about the functionality available within a module not about each settings option and available permissions in particular (https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...). if you compare it with the help page of the node module permissions are summarized in one dedicated point:

User permissions
The Node module makes a number of permissions available for each content type, which can be set by role on the permissions page.

aside that permissions are only mentioned in some of the others points.

but aside the points in the uses section i would definitely update the about section as well. removing the link to the custom block module documentation. it is basically more or less the same as the current help page for the block content module: https://www.drupal.org/documentation/modules/block_content. therefore it is sort of redundant information.
but on the other hand i would also add one important piece of information to the about section. that you are able to create content blocks in two locations within the drupal admin interface. content blocks created in /admin/content/block (the new path) are reusable content blocks and content blocks created within layout builder are none reusable content blocks aka inline block (or what name will be agreed on in #3318558: Adjust the block terminology in Layout Builder to align with block and block_content changes). but i consider that detail not well documented and clear to the user. me for example i've learned and understood it completely in the course of the whole reorganizing the block items issue. and it is also something that wasn't clear to everyone who has attended the feedback sessions in the different user groups i've visited.

This was extremely out of date, some of these sections were moved to Help topics. I've attempted to apply the relevant suggestions from https://git.drupalcode.org/project/drupal/-/merge_requests/3806 to a new MR against 11.x

I think it would be good to quickly get something in that may not be perfect so we can remove references to old permissions/naming ASAP and then iterate on wording later.

Thanks for picking this up.

Reviewed the changes and they appear correct to me. Don't need tests for help text.

the wording need a little bit more work, let's try to get a native, documentation-inclined person to help out

Removing Novice tag based on #20

The sentence in question doesn't seem to belong in block content's help anyway so IMO we can just remove that therefore this is back to NR.

LGTM

Committed 0e61b8c and pushed to 11.x. Thanks!

Not backporting to 11.2.x because this is a string change.

Should this be backported to 10.6.x?