Problem/Motivation

In the contextual module, there is 14 references to code that should have been removed in D10 but remains in the codebase.

These references are in the following files

contextual.js
StateModal.js
AuralView.js
VisualView.js
KeyboardView.js
RegionView.js

Steps to reproduce

See the deprecation messages in the files.

Proposed resolution

The next plan of attack would be to decide what to do with these? Can they be safely removed now or should we bump the deprecation message to say they're now removed from Drupal 11? It looks like most of them are tied to Backbone.js

Remaining tasks

Audit use of the deprecated functions and properties and decide what we want to do.

User interface changes

Potentially - If these deprecations are still working it may result in changes

API changes

A number of properties and functions will be removed.

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3352548-8.patch6.63 KBgauravvvv

Issue fork drupal-3352548

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DanielVeza created an issue. See original summary.

DanielVeza opened merge request !3783

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Status: Active » Needs review
Parent issue: » #3284879: [meta] Requirements for tagging Drupal 11.0.0-beta1

Updated the deprecations to Drupal 11 after advice from @xjm

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Good cleanup.

  • larowlan committed 4735bc2f on 10.0.x 
    Issue #3352548 by DanielVeza: Leftover D10 deprecations in the...

  • larowlan committed 21e847cf on 10.1.x 
    Issue #3352548 by DanielVeza: Leftover D10 deprecations in the...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 10.1.x-dev » 9.5.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 10.1.x and backported to 10.0.x after ensuring it passed core commit checks.

We'll need a separate patch/MR for 9.5.x because of the .es6.js and .js files.

Setting to Patch (to be ported)

gauravvvv’s picture

gauravvvv commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 3352548-8.patch6.63 KB

I have attached patch for 9.5.x. please review

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs review » Reviewed & tested by the community

Good catch from @Gauravvvv

Moving to RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yep good spot. Committed/pushed to 9.5.x, thanks!

  • catch committed 01a584e6 on 9.5.x 
    Issue #3352548 by DanielVeza, Gauravvvv, larowlan: Leftover D10...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Parent issue: #3284879: [meta] Requirements for tagging Drupal 11.0.0-beta1 » #3301206: [meta] Fix incomplete/incorrect deprecations in Drupal core