Problem/Motivation

We have various incomplete/incorrect deprecations in Drupal core, most of these were added early in the 8.x cycle before we had a finished deprecation API and test support.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

catch created an issue. See original summary.

quietone’s picture

quietone commented
Issue tags: +Drupal 10 beta should-have

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Opened:
#3318985: Bump REQUEST_TIME deprecation to Drupal 11
#3318988: Finish deprecating status code and header assertions in JS tests

andypost’s picture

andypost
he/him
Primary language Russian
commented

One more issue #3318342: DeprecatedServicePropertyTrait should point to 11.0

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Fix incomplete/incorrect deprecations in Drupal core » [meta] Fix incomplete/incorrect deprecations in Drupal core
Category: Task » Plan
Issue tags: -Drupal 10 beta should-have
Parent issue: » #3284879: [meta] Requirements for tagging Drupal 11.0.0-beta1

This is meta-ish so let's do this.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
commented

The biggest child issue fixed finally! - #2902895: [meta][no patch] Replace uses of REQUEST_TIME and time() with time service

andypost’s picture

andypost
he/him
Primary language Russian
commented

2 child issues left

both needs work, but #3318988: Finish deprecating status code and header assertions in JS tests can just update for removal in 12.x

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented

Is there anything more to do here? If so, how to find them?

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Fixed

This is a legacy item in the meta from the 8/9 to 9/10 cycle. Since all the child issues are resolved, I would recommend we change the standing bullet in the template to "Identify and address any incomplete deprecations (if needed)", and only create a parent meta next cycle if issues come up.

Re: Finding them, the problem is of course that these are the things we can't find with tooling because the deprecations were incomplete or non-standard. But like the IS says, these were mostly from D8 days and we've fixed them by now.

By its very nature, this is a meta of best effort to include what we do find (or what comes up organically over a cycle). So, we can call this fixed for D12 (and 11, and 10).

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.