Postponed (maintainer needs more info)
Project:
Claro
Version:
3.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Mar 2023 at 16:01 UTC
Updated:
21 Sep 2026 at 15:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gauravvvv commentedI have removed the
role="button". attached patch for same.Comment #4
guru2023 commentedI will review this patch.
Comment #5
guru2023 commentedVerified the patch #2 and reviewed it. The patch works fine and I have added the before and after screenshots for reference.
ready for RTBC.
Comment #7
rohan-sinha commentedCreated MR for the issue for convenience.
Comment #8
smustgrave commentedAgree it should be removed there but wonder if it should be added to the summary as that does accordion functionality.
Comment #9
akshay kashyap commented@Gauravvvv Thanks for the Work. Applied patch #2 cleanly. Removed role=button on a status report page.
Comment #11
gauravvvv commentedAdded role=button to summary as that does accordion functionality.
Comment #12
akshay kashyap commentedVerified patch #11 and reviewed it. The patch works fine and I have added the screenshots for reference.
ready for RTBC.
Comment #13
akshay kashyap commentedComment #14
larowlanRemoving credit for creating an MR when there was already a patch.
Removing credit for rebasing the MR
Comment #15
larowlanAccording to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/summary#techni... there are no permitted roles for a summary element and button is implied, so this change is not correct
Comment #16
gauravvvv commentedAddressed #15, attached interdiff for same. please review
Comment #18
chi commentedRe #15 Drupal always applies
role="button"to summary elements. See #1848684: Add ARIA role to DETAILS. However, it's important that along withrole="button"the summary element should get a certain combination of aria attributes. Namely,aria-controls,aria-expanded,aria-pressed. Those are needed to make the details/summary element behave like a disclosure widget. Otherwise the summary would become a simple button and screen readers will not announce the state of the element. Which would make things much worse.Here are some details.
https://www.scottohara.me/blog/2022/09/12/details-summary.html#consisten...
Given that #1848684: Add ARIA role to DETAILS was discussed ten years ago we might need to rethink the whole approach. This might be no longer needed at all.
Comment #21
vinmayiswamy commentedHi everyone,
I've attempted to rebase the MR !3731 to the 11.x branch, but unfortunately, a large number of unrelated commits also showed up in the MR. I tried to revert my changes a few times, but I couldn't fully restore it to the original state. As a result, multiple comments and commits are added here as I tried to clean things up.
I apologize for the mess. Could someone please help me restore the MR to its previous state? Any assistance to get this back on track would be greatly appreciated.
Thanks!
Comment #22
vinmayiswamy commentedI've addressed #18 in this patch. Please review.
Comment #24
quietone commentedThe Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.
Comment #25
smustgrave commentedClaro has moved to contrib
But could use an IS update.