I think there is no point to make button from div element.
https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/themes/clar...

Issue fork drupal-3350384

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Chi created an issue. See original summary.

gauravvvv’s picture

Status: Active » Needs review
StatusFileSize
new827 bytes
new411 KB

I have removed the role="button". attached patch for same.

rckstr_rohan made their first commit to this issue’s fork.

guru2023’s picture

Assigned: Unassigned » guru2023

I will review this patch.

guru2023’s picture

Assigned: guru2023 » Unassigned
StatusFileSize
new210.47 KB
new208.37 KB
new153.21 KB

Verified the patch #2 and reviewed it. The patch works fine and I have added the before and after screenshots for reference.
ready for RTBC.

rohan-sinha’s picture

Created MR for the issue for convenience.

smustgrave’s picture

Agree it should be removed there but wonder if it should be added to the summary as that does accordion functionality.

akshay kashyap’s picture

StatusFileSize
new103.53 KB
new104.16 KB

@Gauravvvv Thanks for the Work. Applied patch #2 cleanly. Removed role=button on a status report page.

VladimirAus made their first commit to this issue’s fork.

gauravvvv’s picture

StatusFileSize
new1.46 KB
new970 bytes

Added role=button to summary as that does accordion functionality.

akshay kashyap’s picture

StatusFileSize
new120.78 KB
new147.28 KB

Verified patch #11 and reviewed it. The patch works fine and I have added the screenshots for reference.
ready for RTBC.

akshay kashyap’s picture

Status: Needs review » Reviewed & tested by the community
larowlan’s picture

Removing credit for creating an MR when there was already a patch.
Removing credit for rebasing the MR

larowlan’s picture

Status: Reviewed & tested by the community » Needs work

According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/summary#techni... there are no permitted roles for a summary element and button is implied, so this change is not correct

+++ b/core/themes/claro/templates/status-report-grouped.html.twig
@@ -22,7 +22,7 @@
-      <summary id="{{ group.type }}" class="claro-details__summary claro-details__summary--system-status-report">{{ group.title }}</summary>
+      <summary id="{{ group.type }}" class="claro-details__summary claro-details__summary--system-status-report" role="button">{{ group.title }}</summary>
gauravvvv’s picture

Status: Needs work » Needs review
StatusFileSize
new827 bytes
new970 bytes

Addressed #15, attached interdiff for same. please review

Status: Needs review » Needs work

The last submitted patch, 16: 3350384-16.patch, failed testing. View results

chi’s picture

Re #15 Drupal always applies role="button" to summary elements. See #1848684: Add ARIA role to DETAILS. However, it's important that along with role="button" the summary element should get a certain combination of aria attributes. Namely, aria-controls, aria-expanded, aria-pressed. Those are needed to make the details/summary element behave like a disclosure widget. Otherwise the summary would become a simple button and screen readers will not announce the state of the element. Which would make things much worse.

Here are some details.
https://www.scottohara.me/blog/2022/09/12/details-summary.html#consisten...

Given that #1848684: Add ARIA role to DETAILS was discussed ten years ago we might need to rethink the whole approach. This might be no longer needed at all.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vinmayiswamy made their first commit to this issue’s fork.

vinmayiswamy’s picture

Hi everyone,

I've attempted to rebase the MR !3731 to the 11.x branch, but unfortunately, a large number of unrelated commits also showed up in the MR. I tried to revert my changes a few times, but I couldn't fully restore it to the original state. As a result, multiple comments and commits are added here as I tried to clean things up.

I apologize for the mess. Could someone please help me restore the MR to its previous state? Any assistance to get this back on track would be greatly appreciated.

Thanks!

vinmayiswamy’s picture

StatusFileSize
new919 bytes

I've addressed #18 in this patch. Please review.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

Title: Claro: role=button on status report items » role=button on status report items
Status: Needs work » Postponed

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.

smustgrave’s picture

Project: Drupal core » Claro
Version: main » 3.0.x-dev
Component: Claro theme » Code
Status: Postponed » Postponed (maintainer needs more info)
Issue tags: +Needs issue summary update

Claro has moved to contrib

But could use an IS update.