Closed (fixed)
Project:
CKEditor Accordion
Version:
2.0.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
13 Mar 2023 at 09:57 UTC
Updated:
15 Dec 2023 at 06:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
icurk commentedPatch fixing the deprecated code.
Comment #3
icurk commentedComment #4
alvarodemendoza commentedThis is working all right. Moving to RTBC.
Comment #5
alvarodemendoza commentedComment #6
jkamizato commentedTested, good job @icurk !!!
I've changed to priority major, because without this patch Drupal 10 broke.
Comment #7
adrianopulzIt worked fine on Drupal 10 and fixed the problem. Great work @icurk!
Comment #8
sascha_meissnerTested the patch, it´s working fine :-)
Comment #9
samlerner commentedThis worked for me too!
Raising this to Critical because as jkamizato said, without this patch, you can't get this module working at all in D10. And we're only 2 months away from D9 being EOL.
Comment #10
o_timoshchuk commented+1 RTBC
Comment #11
toki+1 RTBC
Comment #12
andyf commentedThanks everyone for the work on this. I hate to push the status back to needs review, but I think there's some unnecessary complexity in the previous patch as the base class already has the required service.
Not sure it's worth an interdiff with such a small patch.
Thanks!
Comment #13
samlerner commentedThank you @AndyF for your update, it's a much cleaner solution. Looks like it's already part of CKEditorPluginBase on https://www.drupal.org/node/2940438
Tested your patch and it also works, thanks so much!
Putting back in RTBC since the update does the same thing as before, just without adding another service.
Comment #14
jkriigel commented#12 +1 RTBC
Comment #15
joseph.olstad#12 +1
Comment #16
spais commentedTested patch #12 and it works, thank you!
Comment #17
seattlehimay commented#12 Tested and working for me too. Thanks!
Comment #18
mepperly commented#12 Tested and working! Thanks for this
Comment #19
vaish commentedTested patch #12. It's working. Thanks.
Comment #20
joseph.olstadI've sent a contact message to both of the maintainers. If they do not respond in another 2 weeks, déclenche un virage
Comment #21
j-vee commentedFixed in 2.1.0. Thanks everyone!