drupal_get_path() function is being deprecated and need to be replaced with the correct service.

Comments

icurk created an issue. See original summary.

icurk’s picture

Patch fixing the deprecated code.

icurk’s picture

Status: Active » Needs review
alvarodemendoza’s picture

StatusFileSize
new53.25 KB

This is working all right. Moving to RTBC.

alvarodemendoza’s picture

Status: Needs review » Reviewed & tested by the community
jkamizato’s picture

Priority: Normal » Major

Tested, good job @icurk !!!

I've changed to priority major, because without this patch Drupal 10 broke.

adrianopulz’s picture

It worked fine on Drupal 10 and fixed the problem. Great work @icurk!

sascha_meissner’s picture

Tested the patch, it´s working fine :-)

samlerner’s picture

Priority: Major » Critical

This worked for me too!

Raising this to Critical because as jkamizato said, without this patch, you can't get this module working at all in D10. And we're only 2 months away from D9 being EOL.

o_timoshchuk’s picture

+1 RTBC

toki’s picture

+1 RTBC

andyf’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new905 bytes

Thanks everyone for the work on this. I hate to push the status back to needs review, but I think there's some unnecessary complexity in the previous patch as the base class already has the required service.

Not sure it's worth an interdiff with such a small patch.

Thanks!

samlerner’s picture

Status: Needs review » Reviewed & tested by the community

Thank you @AndyF for your update, it's a much cleaner solution. Looks like it's already part of CKEditorPluginBase on https://www.drupal.org/node/2940438

Tested your patch and it also works, thanks so much!

Putting back in RTBC since the update does the same thing as before, just without adding another service.

jkriigel’s picture

#12 +1 RTBC

joseph.olstad’s picture

#12 +1

spais’s picture

Tested patch #12 and it works, thank you!

seattlehimay’s picture

#12 Tested and working for me too. Thanks!

mepperly’s picture

#12 Tested and working! Thanks for this

vaish’s picture

Tested patch #12. It's working. Thanks.

joseph.olstad’s picture

I've sent a contact message to both of the maintainers. If they do not respond in another 2 weeks, déclenche un virage

j-vee’s picture

Status: Reviewed & tested by the community » Fixed

Fixed in 2.1.0. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.