The project

Drupal Symfony Mailer is a new mail-system based on the popular Symfony Mailer library giving full support of HTML mails, file attachments, embedded images, 3rd-party delivery integrations, load-balancing/failover, signing/encryption, async sending and more. Other libraries add capability for CSS inlining and HTML to text conversion.

Goals:

  1. Drop-in replacement with minimal migration steps for the popular swiftmailer module, which became unsupported end Nov 2021.
  2. Provide improved API and configuration model for sites that are willing to adapt. This module provides a deep integration into Drupal mechanisms, including theme/template/render, multi-language, CSS libraries, configuration, plug-ins, hooks, and logging.
  3. Allow sites to evolve smoothly from the first to the second.

The module is already in use on approx 6000 sites, and now has the first stable release. These sites are eagerly awaiting opt-in to security coverage.

The author

AdamPS is maintainer for 6 Drupal modules, and an active contributor on several others. Some of the modules I wrote fully myself, others I took over from others. Some modules are already stable. This is the first modules I wrote myself that is ready to be stable, hence this application.

Project link

https://www.drupal.org/project/symfony_mailer

Comments

AdamPS created an issue. See original summary.

vishal.kadam’s picture

vishal.kadam
Location Mumbai
commented

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

vishal.kadam’s picture

vishal.kadam
Location Mumbai
commented
Title: Drupal Symfony Mailer [D9/10] » [1.x] Drupal Symfony Mailer
Issue summary: View changes
vishal.kadam’s picture

vishal.kadam
Location Mumbai
commented
Status: Needs review » Needs work

1. Fix PHPCS issues. You can use the PHPCS tool for checking and resolving issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml symfony_mailer/

FILE: symfony_mailer/tests/modules/symfony_mailer_legacy_test/symfony_mailer_legacy_test.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | "Description" property is missing in the info.yml file
--------------------------------------------------------------------------------


FILE: symfony_mailer/tests/modules/symfony_mailer_legacy_test/symfony_mailer_legacy_test.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------


FILE: symfony_mailer/tests/modules/symfony_mailer_test/symfony_mailer_test.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | "Description" property is missing in the info.yml file
--------------------------------------------------------------------------------


FILE: symfony_mailer/tests/src/Kernel/SymfonyMailerKernelTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 22 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------

2. add README.md file

adamps’s picture

adamps commented
Status: Needs work » Needs review

Thanks both done

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
adamps’s picture

adamps commented

Great many thanks for a very quick review😃

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.