Problem/Motivation

The entity containing a broken link is shown in the report via views field 'Page entity label' (LinkcheckerLinkPageEntityLabel).

If the entity is translated it is shown with wrong label and linked to wrong translation.

Steps to reproduce

  • Create node type with link field checked by linkchecker
  • Add node with broken URL
  • Translate node, remember to translate the node title
  • Run broken links cron
  • Check broken links report (Administration > Reports > Broken links):
    both nodes are shown with correct "Language: ..." but label and link are the same.

Proposed resolution

Check in LinkcheckerLinkPageEntityLabel::render() if $linked_entity is translatable and translate it accordingly.

Remaining tasks

Testing would be great.

User interface changes

Broken links report shows translated title and links to translated entity.

CommentFileSizeAuthor
#6 Captura desde 2023-04-21 12-07-25.png51.09 KBcarlitus
#6 Captura desde 2023-04-21 12-07-53.png51.3 KBcarlitus
#6 Captura desde 2023-04-21 12-08-36.png79.88 KBcarlitus
#6 Captura desde 2023-04-21 12-08-44.png61.8 KBcarlitus
#5 linkchecker-3334610-interdiff-2-5.txt733 bytesgngn
#5 linkchecker-3334610-translate-entity-5.patch1.21 KBgngn
#2 linkchecker-3334610-translate-entity.patch1.13 KBgngn

Issue fork linkchecker-3334610

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gngn created an issue. See original summary.

gngn’s picture

gngn commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new linkchecker-3334610-translate-entity.patch1.13 KB

Patch as proposed above.

Feedback welcome.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Issue tags: +Needs tests

Very cool, thanks! ❤️

Are you able to write a small test for this as well?

gngn’s picture

gngn commented

@eiriksm thank you :)

About "a small test for this" ... I can give it a try (I don't have much experience with drupal tests though).

gngn’s picture

gngn commented
StatusFileSize
new linkchecker-3334610-translate-entity-5.patch1.21 KB
new linkchecker-3334610-interdiff-2-5.txt733 bytes

I still have no test - but I tested a bit.

Turns out I forgot to check if the $linked_entity actually has the translation.
So #2 fails e.g. with a pararaph embedded in an untranslated node.
Fixed.

carlitus’s picture

carlitus commented
StatusFileSize
new Captura desde 2023-04-21 12-08-44.png61.8 KB
new Captura desde 2023-04-21 12-08-36.png79.88 KB
new Captura desde 2023-04-21 12-07-53.png51.3 KB
new Captura desde 2023-04-21 12-07-25.png51.09 KB

The patch #5 works well for me. Attached screenshots:

The field in english:
Field in english

The field in spanish:
Field in spanish

Reports without patch, where it shows the link to wrong language:
Reports without patch

Reports with the patch, where it shows the link to right language:
Reports with the patch

Thanks @gngn!

lisotton’s picture

lisotton commented
Status: Needs review » Reviewed & tested by the community

I tested and it works fine.
Moving to RTBC also according to @carlitus evidences.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Reviewed & tested by the community » Needs work

Still needs tests ✌️🤓

Also, please use a merge request so the testing pipelines can run

shivam_tiwari’s picture

shivam_tiwari commented
Assigned: Unassigned » shivam_tiwari

I am working here.

shivam_tiwari opened merge request !105

shivam_tiwari’s picture

shivam_tiwari commented
Version: 8.x-1.x-dev » 2.1.x-dev

shivam_tiwari opened merge request !106

shivam_tiwari closed merge request !105

shivam_tiwari’s picture

shivam_tiwari commented
Assigned: shivam_tiwari » Unassigned
Status: Needs work » Needs review

Created MR 106 for the latest development version. Pipeline is green so moving it to Needs Review.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Fixed

Alright looks simple enough. Let's do tests in a follow up

Thank to everyone who worked on this! ♥️🚀

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented

Created https://www.drupal.org/project/linkchecker/issues/3506219 for the tests

c-logemann’s picture

c-logemann
he/him
Primary language German
Location Frankfurt/M, Germany
commented
Related issues: +#3506219: Create tests for showing the translated entity link
c-logemann’s picture

c-logemann
he/him
Primary language German
Location Frankfurt/M, Germany
commented
Related issues: -#3506219: Create tests for showing the translated entity link

Oh, was already connected as parent issue. Sorry for the noise.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.