Closed (fixed)
Project:
OpenChurch Core
Version:
3.0.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Jan 2023 at 12:01 UTC
Updated:
8 Feb 2023 at 22:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
shubham rathore commentedComment #4
shubham rathore commentedHi create MR for README.md file update.
Please review.
Thanks.
Comment #5
drupalninja99 commentedComment #6
renatog commentedHello. I was reading here the README but I think it can be improved.
Look that there are some duplicated informations there:
#1 On description there is a sentence
#2 On session "Requirements" also have this information:
#3 On session "Configuration" there is a duplicated information as well:
The module has no modifiable settings - There is no configuration.So I think it can be improved
Comment #7
renatog commentedUpdated the MR with these improvements in the README: https://git.drupalcode.org/project/openchurch_core/-/merge_requests/3
Comment #8
rinku jacob 13 commentedI have reviewed the merge request !3. I can see the changes on the file which is made by @Renatog. Thanks @shubham and @Renatog. Adding screenshot for the reference. Need +1RTBC
Comment #9
renatog commentedSo based on feedback from #8, updating the status to RTBC
Comment #10
drupalninja99 commentedI also want to link to the OpenChurch Gitbook from the README which has full details: https://openchurch.gitbook.io/guide/
Comment #11
renatog commentedMakes sense - Updating as "Needs Works" to include the Gitbook
Comment #13
renatog commentedAdded the Gitbook. MR updated: https://git.drupalcode.org/project/openchurch_core/-/merge_requests/5
Comment #14
renatog commentedAh yeah, I think the branch of MR was updated with the code from branch
3.0.xright?!Makes sense for me
Comment #16
renatog commentedGreat! @drupalninja99 since it was committed into 3.0.x, could you please close the ticket as "fixed", please?
It'll reduce the open items in the issue queue
Comment #17
drupalninja99 commented