Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 Screenshot 2023-06-14 173249.png21.36 KBarti_parmar
#2 Drupal_calls_should_be_avoided_in_classes_use_dependency_injection_instead-3330312-2.patch3.36 KBmaithri shetty

Issue fork eu_cookie_compliance-3330312

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Maithri Shetty created an issue. See original summary.

maithri shetty’s picture

maithri shetty commented
Assigned: maithri shetty » Unassigned
Status: Active » Needs review
StatusFileSize
new Drupal_calls_should_be_avoided_in_classes_use_dependency_injection_instead-3330312-2.patch3.36 KB
atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

I will review this patch.

arti_parmar’s picture

arti_parmar commented
Assigned: atul_ghate » arti_parmar
Category: Task » Bug report

I review your patch.

arti_parmar’s picture

arti_parmar commented
StatusFileSize
new Screenshot 2023-06-14 173249.png21.36 KB

I have reviewed this patch but patch is not applied cleanly.
Thanks

arti_parmar’s picture

arti_parmar commented
Status: Needs review » Needs work
arti_parmar’s picture

arti_parmar commented
Assigned: arti_parmar » Unassigned

shivam_tiwari made their first commit to this issue’s fork.

shivam_tiwari opened merge request !121

shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs work » Needs review
arpitk’s picture

arpitk commented
Assigned: Unassigned » arpitk
Status: Needs review » Needs work

I reviewed the MR the current changes crashed the modules. Providing the updated MR.
ArgumentCountError: Too few arguments to function Drupal\eu_cookie_compliance\EventSubscriber\EuCookieComplianceConfigEventsSubscriber::__construct(), 0 passed in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 3 expected in Drupal\eu_cookie_compliance\EventSubscriber\EuCookieComplianceConfigEventsSubscriber->__construct() (line 65 of /app/web/modules/contrib/eu_cookie_compliance/src/EventSubscriber/EuCookieComplianceConfigEventsSubscriber.php)

Thanks!

arpitk’s picture

arpitk commented
Assigned: arpitk » Unassigned
Status: Needs work » Needs review
Issue tags: +Coding standards
arti_parmar’s picture

arti_parmar commented
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Category: Bug report » Task
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

The issue summary should always describe what should be fixed/changed. Neither the title nor screenshots are sufficient to describe what the issue is, even in the case a patch is provided.

svenryen’s picture

svenryen commented
Status: Needs work » Closed (duplicate)

We fixed this over in #3366721: \Drupal calls should be avoided in classes, use dependency injection instead

Thanks all for the effort.

svenryen closed merge request !121