Problem/Motivation

When send a request of SUB_REQUEST type $this->requestStack->getCurrentRequest()->getSession() returns NULL and therefore we get an error trying to call function get() on NULL.
From Session::handle() method: session is set only for MASTER_REQUEST type requests.
:handle() function

Drupal core version: 9.4.8
Autologout module version: 8.x-1.4

Error message
Error: Call to a member function get() on null in Drupal\autologout\EventSubscriber\AutologoutSubscriber->onRequest() (line 123 of modules/contrib/autologout/src/EventSubscriber/AutologoutSubscriber.php)

Steps to reproduce

  • Find any usage of sub request (e.g. search for ->handle($subrequest, HttpKernelInterface::SUB_REQUEST)) and try to send this request so it would lead to AutologoutSubscriber::onRequest() method and cause the issue
  • OR
  • Install Ctools module
  • Install Layout builder library module OR any other module that allows to add conditions(e.g. pathauto_condition_ui provided by pathauto module
  • try to add a condition on Manage conditions page manage conditions page
CommentFileSizeAuthor
#6 autologout-subscriber-empty-session-3328196-6.patch776 bytessergey.semchuk
#3 autologout-subscriber-empty-session-php-v8-3328196-3.patch617 bytessergey.semchuk
#2 autologout-subscriber-empty-session-3328196-2.patch688 bytessergey.semchuk
Screenshot from 2022-12-20 10-59-23.png13.23 KBsergey.semchuk
Screenshot from 2022-12-20 07-46-21.png47.13 KBsergey.semchuk

Issue fork autologout-3328196

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sergey.semchuk created an issue. See original summary.

sergey.semchuk’s picture

sergey.semchuk commented
StatusFileSize
new autologout-subscriber-empty-session-3328196-2.patch688 bytes

PHP 7 patch

sergey.semchuk’s picture

sergey.semchuk commented
StatusFileSize
new autologout-subscriber-empty-session-php-v8-3328196-3.patch617 bytes

PHP 8 patch

sergey.semchuk’s picture

sergey.semchuk commented
Status: Active » Needs review
the_g_bomb’s picture

the_g_bomb commented

Failing because the nullsafe operator is available from PHP8, but the test is using PHP7.4

sergey.semchuk’s picture

sergey.semchuk commented
StatusFileSize
new autologout-subscriber-empty-session-3328196-6.patch776 bytes

Updated the patch to fix the issue in Drupal 10 because `getSession()` method started throwing `BadMethodCallException('Session has not been set.')` and it's recommended to use `hasSession()` method.

admirlju made their first commit to this issue’s fork.

admirlju opened merge request !50

admirlju’s picture

admirlju commented

Created a merge request to use GitlabCI testing. Also changed that null safe operator, since the module, for now, supports Drupal 9 even if it's going to be EOL in less than a month, and since it can technically run on php7.4 it's better to program with those limitations in mind.

  • japerry committed 6b1e8ae4 on 2.x 
    Issue #3328196 by sergey.semchuk, admirlju: Call to a member function...
japerry’s picture

japerry
Location KOMK
commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Needs review » Fixed

rerolled with some other refactored snippets of this code and committed

  • japerry committed 6b1e8ae4 on 8.x-1.x 
    Issue #3328196 by sergey.semchuk, admirlju: Call to a member function...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.