Project Browser Initiative Meeting for October 5, 2022 [#3328117]

1️⃣ Here's the big boy. @timplunkett (he/him) is about to merge! #3284945: Install endpoints that leverage Package Manager + core APIs

timplunkett (he/him)	To hopefully be followed soon by #3312289: Svelte UI for install controllers!
chrisfromredfin	Want to acknowledge super hard work done across strategic initiatives to make this happen! Thanks so much to @tedbow @phenaproxima @bnjmnm and @timplunkett (he/him) on this one. 61 commits!!
chrisfromredfin	Yes, good point - even once this one's in, there's no UI to actually do it until the above :point_up:
bnjmnm	61 commits!!
bnjmnm	On a branch I created last week because the histories were too insane on the others 🙂
timplunkett (he/him)	Merged! :party_gritty:
bnjmnm	The GUI part is blocked on the stuff being discussed here https://drupal.slack.com/archives/C7QJNEY3E/p1664888020584219 It's possible to make some progress, but the actual install process won't complete if there are symlinks and node_modules has a bunch of em. This means having to rm -r node_modules before trying an install, then having to do a new yarn install before making any changes to svelte
timplunkett (he/him)	That's certainly a PITA for us, but won't affect end users...
bnjmnm	All signs point to this being addressable, and there's reasons beyond Project Browser that it is necessary
bnjmnm	It can probably be reviewed right now once I get it synced up.
chrisfromredfin	Is there an autoupdates issue that's been filed re: the above-linked discussion that we can follow?
timplunkett (he/him)	good q, I asked in the thread
tedbow	re the symlinks issue @TravisCarden is working on that now. It will be handled mostly in composer-stager a php library that underlines all of this(no pressure :wink:)
tedbow	once the that part is done well have to make some changes in package_manager.then if project_browser is already excluding the node_modules directory it would automatically be exempted from the symlinks checking
timplunkett (he/him)	@tedbow can you open a stub issue for that and tag it Package Manager integration in Project Browser?
tedbow	yep
leslieg	Wow - I need to update my BADCamp slides. Thanks @timplunkett (he/him), @tedbow @phenaproxima @bnjmnm and everyone else who worked together to make this happen.
timplunkett (he/him)	fwiw the UI portion will likely land after BADCamp. but still exciting!
timplunkett (he/him)	(also the fact that BADCamp is happening tomorrow is really making me grapple with the fact that it's somehow OCTOBER already :exploding_head:)
chrisfromredfin	:musical_note: leaves are fallin' all around... time, I was on my way (to BADCamp)
tedbow	@timplunkett (he/him) #3313649: Pass all path exclusions in SymlinkValidator#comment-14720178

2️⃣ If anyone has some quick general thoughts on #3282338: Use git hooks to prevent push if yarn build was not run#comment-14719083 I'd appreciate them. I'm thinking of using postinstall of yarn scripts to implement the git hook in the project repo - feels a little kludgey but may work and benefit new contributors if it can work reliably.

fjgarlin	is PB already on the GitLab CI list?
chrisfromredfin	Yes. My DevOps guy is here in the office with me today I'm going to review the work I already started with him and the Spoons stuff and see where he can land in the next few weeks. What we're trying to do with the above, though, is prevent something simple without using Association resources 🙂
fjgarlin	awesome. just asking because maybe we can leverage GitlabCI to compile assets and put them in the repo. not sure how, just a thought
chrisfromredfin	Oh yes, even better. So we aren't even committing the bundles!
chrisfromredfin	I know we can do that with CI I think.
chrisfromredfin	GitLab CI I mean
fjgarlin	correct. that’s my thinking

3️⃣ Handful of things that need review that people could look at. Anything RTBC right now will also currently need a rebase: https://www.drupal.org/project/issues/search/project_browser?project_iss...…]d=&submitted=&&&issue_tags=&order=field_issue_status&sort=asc - if people are looking for some light-ish tasks.

fjgarlin	I just rebased this one: #3307512: Alter default sorting options in plugins
chrisfromredfin	@timplunkett (he/him) there's a bunch of smallish UI fixes that could go in that are RTBC. Do we want to do a bunch of those and then rebase the Svelte UI or continue holding off? I haven't looked at the Svelte UI one to see how many / which components it touches
chrisfromredfin	I defer to you but if you pick rebasing Svelte UI then I can do a bunch of these small commits
timplunkett (he/him)	Each of those would like cascade to a rebase of the next anyway. I'd like to hold off for a few more days, and in the meantime I can do a thorough review of each to ensure they're actually ready for merge
chrisfromredfin	sounds good