Problem/Motivation

The function drupal_get_path() used on BlockClassHelperService.php is deprecated based on #2940438: drupal_get_path() and drupal_get_filename() have been deprecated in favor of extension listing services.

Proposed resolution

Inject and use the proper service.

Issue fork block_class-3323004

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jidrone created an issue. See original summary.

jidrone opened merge request !8

jidrone’s picture

jidrone commented
Status: Active » Needs review

MR opened and changed to Needs Review

ankitjhakal’s picture

ankitjhakal commented
Assigned: Unassigned » ankitjhakal
ankitjhakal’s picture

ankitjhakal commented
Assigned: ankitjhakal » Unassigned
Status: Needs review » Reviewed & tested by the community

Tested changes on local, able to resolve the issue so moving this to RTBC status.

renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Needs work

Thanks everyone

I was going to merge but need Re-rool and update the pull request: https://git.drupalcode.org/project/block_class/-/merge_requests/8

Merge blocked: the source branch must be rebased onto the target branch.
renatog’s picture

renatog commented
Issue tags: +Needs reroll, +Novice

sourabhjain made their first commit to this issue’s fork.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll

@renatoG I have rerolled the patch. Please review and merge it now.

sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput

I will review this patch

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
Status: Needs review » Reviewed & tested by the community

MR is reviewed its looking good to me so moving to RTBC

jidrone’s picture

jidrone commented
Status: Reviewed & tested by the community » Needs review

Rerolled MR

sahilgidwani’s picture

sahilgidwani commented
Assigned: Unassigned » sahilgidwani
sahilgidwani’s picture

sahilgidwani commented
Assigned: sahilgidwani » Unassigned
Status: Needs review » Reviewed & tested by the community

Reviewed and checked MR and it works perfect.

VladimirAus made their first commit to this issue’s fork.

chris matthews’s picture

chris matthews commented
Parent issue: » #3363340: Plan for 2.0.12 Release of Block Class

DYdave closed merge request !8

dydave’s picture

dydave commented
Category: Bug report » Task
Status: Reviewed & tested by the community » Fixed
Related issues: +#3392942: Fix the issues reported by phpcs

This was fixed in #3392942: Fix the issues reported by phpcs and committed to the 2.0.x branch.

Thanks everyone for the great work on this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.