Problem/Motivation

FieldInheritancePluginBase::__construct() expects the key value store to be an instance of KeyValueFactory, which will throw an error if that service is swapped out (for example, in a kernel test case, where it may be KeyValueMemoryFactory instead).

Proposed resolution

Change the class to use KeyValueFactoryInterface.

Issue fork field_inheritance-3321274

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

muriqui created an issue. See original summary.

muriqui opened merge request !4

muriqui’s picture

muriqui commented
Status: Active » Needs review
owenbush’s picture

owenbush commented
Status: Needs review » Reviewed & tested by the community

Looks good, thank you for the MR.

  • owenbush committed d1439b0 on 2.0.x authored by muriqui 
    Issue #3321274 by muriqui: FieldInheritancePluginBase::__construct()...

  • owenbush committed ca61a1a on 8.x-1.x authored by muriqui 
    Issue #3321274 by muriqui: FieldInheritancePluginBase::__construct()...
owenbush’s picture

owenbush commented
Status: Reviewed & tested by the community » Fixed

This has been merged into the latest dev branches.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.