Problem/Motivation

To make our tests more realistic
\Drupal\Tests\package_manager\Traits\FixtureUtilityTrait::addPackage

Should make the folder changes in not just the installed.json and installed.php

Steps to reproduce

Proposed resolution

Remaining tasks

at some point we might need to make the folder changes in
\Drupal\Tests\package_manager\Traits\FixtureUtilityTrait::modifyPackage

\Drupal\Tests\package_manager\Traits\FixtureUtilityTrait::removePackage

but right now this is not needed.

User interface changes

API changes

Data model changes

Issue fork automatic_updates-3321236

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow opened merge request !599

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue tags: +sprint
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs work

just getting this started

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Related issues: +#3322589: Assert 'type' key is set in FixtureUtilityTrait::addPackage

These will fail at least because `type` is not set everyone.

Created #3322589: Assert 'type' key is set in FixtureUtilityTrait::addPackage

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » tedbow

#3322589: Assert 'type' key is set in FixtureUtilityTrait::addPackage landed the 18th. Is this ready for review?

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: tedbow » Unassigned
Related issues: +#3322913: Create an easy way for functional tests to simulate an update (and update kernel tests to use the same)

Needs works for

  1. Merging 8.x-2.x again
  2. Investigating the test failure

Unassigning from myself because others could do this

omkar.podey’s picture

omkar.podey commented
Assigned: Unassigned » omkar.podey
omkar.podey’s picture

omkar.podey commented
Assigned: omkar.podey » wim leers
Status: Needs work » Needs review
omkar.podey’s picture

omkar.podey commented
Assigned: wim leers » omkar.podey
Status: Needs review » Needs work
omkar.podey’s picture

omkar.podey commented
Assigned: omkar.podey » Unassigned
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » omkar.podey
Status: Needs review » Needs work

I think this can be simplified slightly more.

2 remarks on the MR — this is very close!

omkar.podey’s picture

omkar.podey commented
Assigned: omkar.podey » Unassigned
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Needs a single line to still be removed (left a suggestion, GitLab won't allow me to apply it 🤷‍♂️).

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: Add actual project folder changes from methods in FixtureUtilityTrait » Add actual project folders in \Drupal\Tests\package_manager\Traits\FixtureUtilityTrait::addPackage
Issue summary: View changes

changing the title and summary to reflect this doesn't affect

\Drupal\Tests\package_manager\Traits\FixtureUtilityTrait::modifyPackage

\Drupal\Tests\package_manager\Traits\FixtureUtilityTrait::removePackage

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: Unassigned » tedbow

assigning to myself to merge when green

thanks @Wim Leers and @omkar.podey!

  • 8f90946 committed on 8.x-2.x 
    Issue #3321236 by tedbow, omkar.podey, Wim Leers: Add actual project...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: tedbow » Unassigned
Status: Reviewed & tested by the community » Fixed
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue tags: +core-mvp

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.