Problem/Motivation

It would be nice if composite sub-elements can have Unique setting options (unique, unique_user, unique_entity, unique_error)

CommentFileSizeAuthor
#11 interdiff-3-11.txt3.61 KBdejan0
#11 webform-add_unique_option_to_webform_sub_elements-3318318-11.patch5.35 KBdejan0
#8 changes_web_form_element_base-3318318-8.patch103.1 KBrohit.rawat619
#7 changes_web_form_element_composite-3317761-4.patch103.1 KBrohit.rawat619
#5 interdiff.txt736 bytesdejan0
#5 webform-add_unique_option_to_webform_sub_elements-3318318-3.patch5.37 KBdejan0
#2 Screenshot from 2022-10-31 13-30-27.png26.76 KBdejan0
#2 webform-add_unique_option_to_webform_sub_elements-3318318-2.patch5.37 KBdejan0

Comments

dejan0 created an issue. See original summary.

dejan0’s picture

dejan0 commented
Status: Active » Needs review
StatusFileSize
new webform-add_unique_option_to_webform_sub_elements-3318318-2.patch5.37 KB
new Screenshot from 2022-10-31 13-30-27.png26.76 KB

please find the patch attached

webform composite unique

cilefen’s picture

cilefen commented
Version: 6.1.x-dev » 6.2.x-dev

I am moving this to the feature branch.

Status: Needs review » Needs work

The last submitted patch, 2: webform-add_unique_option_to_webform_sub_elements-3318318-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

dejan0’s picture

dejan0 commented
StatusFileSize
new webform-add_unique_option_to_webform_sub_elements-3318318-3.patch5.37 KB
new interdiff.txt736 bytes

Fixing an issue with a custom error message.

rohit.rawat619’s picture

rohit.rawat619 commented
Assigned: Unassigned » rohit.rawat619
Status: Needs work » Active
rohit.rawat619’s picture

rohit.rawat619 commented
Assigned: rohit.rawat619 » Unassigned
Status: Active » Needs review
StatusFileSize
new changes_web_form_element_composite-3317761-4.patch103.1 KB
rohit.rawat619’s picture

rohit.rawat619 commented
StatusFileSize
new changes_web_form_element_base-3318318-8.patch103.1 KB
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Needs work

I am very hesitant to add new features and the patch is including unrelated linting and formatting changes which make it challenging to review the change.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Closed (won't fix)

This feature should be handled in a dedicated contributed module.

dejan0’s picture

dejan0 commented
StatusFileSize
new webform-add_unique_option_to_webform_sub_elements-3318318-11.patch5.35 KB
new interdiff-3-11.txt3.61 KB

Rerolled #3 against 6.3.x