Problem/Motivation

Filters radio-buttons are arranged in a way that is difficult for usability.
Project browser filters section with highlight on radio-button groups based on gestalt principles.

This issue was discussed in usability meeting 7 Oct 2022.

Steps to reproduce

Proposed resolution

Rearrange radio-buttons into vertical groups for better correlation with cognitive perception and technical functionality.
Filters area with radio-buttons grouped vertically under each group's labels.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

simohell created an issue. See original summary.

rkoller’s picture

Utkarsh_33 made their first commit to this issue’s fork.

utkarsh_33’s picture

Assigned: Unassigned » utkarsh_33

utkarsh_33’s picture

Assigned: utkarsh_33 » Unassigned
Status: Active » Needs review
rkoller’s picture

Status: Needs review » Needs work
StatusFileSize
new239.06 KB
new106.22 KB

thanks for working on the issue. i've successfully applied MR273. one detail that needs discussion is the huge gutter between the columns. i've taken a screenshot on a widescreen where that gutter is pushed to the extreme:
project browser page with filter component expanded on a widescreen view
stylewise my first thought was if such a huge gutter the filter column should be aligned to the left border of cards for LTR. in the current state of the patch it is does not but for wide screens and it would make the gutter even more broad and even harder for the eyes to process (eventhough the eye would have some sort of guidance by the alignment to the card borders). the better choice might be to make the three columns more compact with a more narrow gutter like in the screenshot in the proposed resolution section. the only thing i wonder is, there isn't one interface element, like checkboxes or radiobuttons, i can think of with more than a single column in the admin interface (aside table layouts like /admin/content, /admin/structure/types/manage/article/form-display and alike) so it might need some design input?

it also has to be discussed how the mobile first output should be handled. with the current patch you get two columns and the third underneath
mobile first view of the project browser page with filter component expanded
would it make sense to make it single column and stack the three filters underneath each other?

simohell’s picture

I my screenshot I was using justify-content: flext-start to align the groups left. It would be good to RTL version also, of course.

I think we should avoid using any width percentages as we don't know the future number on radio-button groups. There has been discussion on possible additional filters. Also in the narrow viewport version we see that width in percentages will create issues.

As for using columns: there are trade-offs between using multiple columns and using sinlge column. I chose to propose multiple columns to avoin scrolling and to have shorter space between filter section top and content section top. Also as the filters work like an accordion it is better if in all/most cases we can see the whole accordion content at once.

utkarsh_33’s picture

Status: Needs work » Needs review
StatusFileSize
new132.93 KB
new124.22 KB

I have attached the screen shots of the latest merge request's results.
Please suggest any other changes if required.

shwetaDevkate’s picture

StatusFileSize
new3.18 KB
tim.plunkett’s picture

@shwetaD I'm not sure what changes you've made since the last commit to the MR. Please make changes there directly (or in a new MR), not in a patch

narendraR made their first commit to this issue’s fork.

srishtiiee’s picture

Status: Needs review » Needs work
StatusFileSize
new124.22 KB

Noticed one small thing, the space between the label and first radio button is too small which is making the text look crowded while the space between the two radio buttons looks sufficient. Can we increase the spacing between the label and the first radio button for all three groups.

utkarsh_33’s picture

Status: Needs work » Needs review
srishtiiee’s picture

Status: Needs review » Reviewed & tested by the community

bnjmnm made their first commit to this issue’s fork.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tim.plunkett’s picture

Issue tags: +core-mvp