When running in Drupal 10, some tests produce

Drupal\Core\Entity\Query\QueryException:
Entity queries must explicitly set whether the query should be access checked or not.
See Drupal\Core\Entity\Query\QueryInterface::accessCheck().

Issue fork scheduler-3313848

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 opened merge request !65

jonathan1055 credited chandu7929.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review

Needs Review to allow testing.
Thanks to @chandu7929 for the initial change.

vishalkhode’s picture

vishalkhode commented

Hi jonathan1055
Reviewed and changes looks good to me. We can move it ahead.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs review » Reviewed & tested by the community

works fine, RTBC

vishalkhode’s picture

vishalkhode commented

Hi chandu7929:
I think following also needs to be updated: https://git.drupalcode.org/project/scheduler/-/merge_requests/65/diffs#a...
I'll run test and update (if more). Thanks

jonathan1055’s picture

jonathan1055 commented
Status: Reviewed & tested by the community » Needs work

That test was only at 9.4. Needs to be run at D10. Let me finish #3312069: ModuleHandlerInterface::getImplementations() is deprecated in 9.4 first, as trying to run anything at D10 fails every test and will obscure the other problems.

chandu7929’s picture

chandu7929 commented
Assigned: Unassigned » chandu7929
jonathan1055’s picture

jonathan1055 commented

Thanks @vishalkhode, yes I knew that. The tests stop at the first problem, so chandu7929 only fixed the first two. I wanted to see the initial problem pass, before fixing those subsequent ones. But if you want to add it now, that's OK.

chandu7929’s picture

chandu7929 commented
Assigned: chandu7929 » Unassigned
Status: Needs work » Needs review
jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Needs work

No downside to committing this on 2.x even though the tests at D10 fail for other reasons. We saw previously that this fixes the deprecation message.

Thanks vishalkhode and chandu7929, will give you credit on the commit.

  • jonathan1055 committed a3a1d4e on 2.x 
    Issue #3313848 by jonathan1055, chandu7929, vishalkhode: Specify...
jonathan1055’s picture

jonathan1055 commented
Status: Needs work » Fixed

Done

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.