Problem/Motivation

Users were confused when testing the Mock API plugin because Best Match uses the relevance score, which the mock does not provide. The Drupal 9 real JSON:API endpoint does work and functions (Fran has demo'd it to me), so I think it _might_ make sense to remove this from the mock api plugin as an option, once https://www.drupal.org/project/project_browser/issues/3307512 goes in.

Steps to reproduce

Using the Mock API source plugin, sort by best match. Note no change.

Proposed resolution

Remove from the mock api plugin.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?

Issue fork project_browser-3310903

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisfromredfin created an issue. See original summary.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Category: Bug report » Plan

I am not 100% convinced that this is the _right_ approach, so open to discussion here.

fjgarlin’s picture

fjgarlin commented
Related issues: +#3307512: Alter default sorting options in plugins

If we decide to alter it, once #3307512: Alter default sorting options in plugins goes in, it's literally just a few lines of code.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Category: Plan » Task

The "Plan" category is used for meta issues

- https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-...

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Assigned: Unassigned » narendrar

Utkarsh_33 made their first commit to this issue’s fork.

Utkarsh_33 opened merge request !294

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Assigned: narendrar » utkarsh_33
Status: Active » Needs work
utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

Tested via drupalpod and reviewed the code. All looks good, marking RTBC.

utkarsh_33’s picture

utkarsh_33 commented
Assigned: utkarsh_33 » Unassigned
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

This can have test coverage

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Needs work
Issue tags: -Needs tests

Just a small nit to address 👍

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs work

Fixing the case on Project Usage is out-of-scope, and made redundant by #3315867: Change the label for the sort by option Project Usage

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3315867: Change the label for the sort by option Project Usage

Changes in this issue or related issue needs to be done once one of the issue is committed.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs work

Needs rebase after committing the other label issue.

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Reviewed & tested by the community » Needs work

Small MR feedback

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review

  • bnjmnm committed 526b7ab on 1.0.x authored by Utkarsh_33 
    Issue #3310903 by Utkarsh_33, bnjmnm, narendraR, tim.plunkett,...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Fixed

Looking good, this gets a merge! Who knows how long the Mock will be used, but it's worth removing from it 🙂

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +core-mvp