Add a plugin for CKEditor5 that is included in Drupal 9.3+ and Drupal 10.

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

Title: Add a CKEditor5 plugin » Add a CKEditor5 plugin for Drupal 9.3+, Drupal 10
gaëlg’s picture

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new20.39 KB

A bare starting point - files from ckeditor5_dev copied & renamed to match.

One problem is that the ckeditor plugin doesn't want to work with shortcodes, so we might be stuck there.

damienmckenna’s picture

StatusFileSize
new20.39 KB

Missed changes to one file.

damienmckenna’s picture

Status: Needs review » Needs work

This may not be possible, I don't see any reference to using shortcodes in ckeditor5.

damienmckenna’s picture

minnur created a merge request which provides a new approach for this functionality with ckeditor 5 and would be a great addition:
https://git.drupalcode.org/project/video_filter/-/merge_requests/7

While I think the better long-term approach would be to migrate to the Media module and just use 3rd party oembed integration, this could be a short-term solution for sites that aren't using the Media system.

Next steps

Split out the ckeditor5 changes from merge request #7 into its own merge request as much of the unrelated changes are being handled as separate issues.

damienmckenna’s picture

Also, now that there's test coverage (#3439443: Add useful functional test) we can finish this off to make sure it works as expected.

abu-zakham’s picture

There is an unresolved conflict in MR7 that must be fixed.