Work out what to do in a CKEditor 5 world that doesn't support shortcodes.

In summary:

  • Drupal 10 is supported for the text filter.
  • CKEditor 4 toolbar button should work when using the contrib module.
  • CKEditor 5 is not supported and may never work.

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3376874: Provide migration path from Video Filter

I opened an issue for Media Migration as it would honestly be the best long-term plan.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3307596: Add a CKEditor5 plugin for Drupal 9.3+, Drupal 10

I started work on a prototype CKEditor 5 plugin (#3307596: Add a CKEditor5 plugin for Drupal 9.3+, Drupal 10), but in my research I could not see how to make it support shortcodes, it seems like it is no longer possible.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2683847: Implement Video Filter token preview in CKEditor

Another issue requesting a preview for CKEditor: #2683847: Implement Video Filter token preview in CKEditor

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Issue tags: +ckeditor5
minnur’s picture

minnur commented

I am currently working on adding CKEditor 5 support.

minnur’s picture

minnur commented

CKEditor 5 support works on my local. Doing some code refactoring and fixing CKEditor 5 previews.

minnur’s picture

minnur commented
Status: Active » Reviewed & tested by the community

https://git.drupalcode.org/project/video_filter/-/merge_requests/7

1. Added support for CKEditor 5
2. Removed deprecated video filter plugins.

Some code cleanup would be nice too, but thats for another day.

minnur’s picture

minnur commented
Status: Reviewed & tested by the community » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
Related issues: +#3433248: Update all URLs to https

Thank you for putting this together.

I updated all of the HTTP URLS to HTTPS, so that part of the MR can be cleaned up.

I also think the changes in the VideoFilter plugins should be reverted to focus on just the ckeditor5 part.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Let's update the existing video plugins in #3433258: Update VideoFilter plugins.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The text filter needs to be reverted so that there's a new text filter for the HTML format from the CKEditor 5 filter, otherwise we'll need to write an upgrade script to handle the new format.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Please create a new merge request in #3307596: Add a CKEditor5 plugin for Drupal 9.3+, Drupal 10 with the new ckeditor5 functionality and a new text filter.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Scrap that last comment, I hadn't finished reading through the merge request and didn't realize that the updated filter could do both the old format and the new format. Nice work!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Fixed

Now that there's a merge request that works for most of what we need, I'm going to close this and ask that we focus on #3307596: Add a CKEditor5 plugin for Drupal 9.3+, Drupal 10, rather than this plan issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

drupalfan2’s picture

drupalfan2 commented

Full CKEditor 5 support is not needed in any case.

But what we need is to add the <video> tag to the allowed html tags of "Filtered HTML" text format.

How can I achieve this?