======== Start of threads for today’s effort ============ Welcome to those here today to help contribute to getting the project data updated. Our goal is for the results returned by the Project Browser to be helpful for out target audience (Site builders and those new to Drupal) when browsing for modules to add to their websites. (edited)

The issue queue can be found at https://www.drupal.org/project/issues/project_browser

The google doc with a link to the Meta Issue for each of the Top 100 Modules that will be returned by default by the Project Browser can be found here. Clicking on the “meta” issue in column A will provide links to the child issues for creating a logo, proposing a short description and suggesting the top 3 categories.

Based on your interest you can select any of the child issues to work on. The meta issue is being used to link the child issues for a specific project (module). The Meta issue also has the instructions for all the child issues - you will need to read and follow these instructions. (edited)

To find the tickets for designing a logo, search the issue queue link above for “logo”. Search for “short description” to suggest a user friendly description. Search for “update categories” to find child issues to propose suggested categories.

1️⃣ if you are here to help us with the project data, say hi and read the instructions above (edited) 

AmyJune (volkswagenchick) Hello! I am interested in helping out with data, but it may be a couple of weeks. I am finishing up some big projects at work and then will have time to commit.
bsnodgrass (he/him) Good Morning, here from St Charles IL western burbs of Chicago...I will be able to dive in for an hour or two, and here for discussions off and on today
leslieg Thanks @AmyJune (volkswagenchick) What’s the status of the Discover Drupal participants. Are they still available to help?
AmyJune (volkswagenchick) @leslieg They are in transition, but I will ask in the channel. It’s a perfect time to check in with them all
AmyJune (volkswagenchick) I’ll also ask in the DrupalEasy space
run fast think slow I am reading above
pearcraft Hello everybody!
leslieg Hi @pearcraft  Are you available to help with some tickets?
pearcraft yes!
leslieg Great. Are you interested in helping with content - creating logos, adding descriptions or selecting the best 1-3 categories for modules?  Or are you looking for a backend or front end coding task?
pearcraft I’m best at categories!
leslieg Great - look for child tickets that have  “Update categories” in the title and are in the “needs work” state. The instructions are on the parent issue - add 1-3 best categories to use as a Proposed Resolution on the ticket and then put ticket in “Needs Review”.  There may be suggestions in the “Top 100” google doc, so check for comments . Let me know if you have any questions.  Whatever you can do over the next week or so would be super helpful.

2️⃣  If you are here to contribute and have an interest in working on the code, please say hello and we’ll help you find an issue.

UjjwalAhluwalia Hello! I am interested in working on the code. I am Ujjwal Ahluwalia from Houston, TX.
chrisfromredfin Hi @UjjwalAhluwalia - we met at DrupalCon did we not? Are you Bakhul's brother?
chrisfromredfin Let me know if you'd like to work more backend / PHP / API - or more front-end Svelte / JS / CSS
UjjwalAhluwalia Hi @chrisfromredfinYes we met in Drupalcon, I am Bakul's brother. I am open to work on both part like backend php/API or frontend JS/CSS.
chrisfromredfin Sweet. Have you contributed to anything before? Usually I get people into the process of contributing with some kind of easier lift first, but if you already know the general process, then I can search for other stuff. My understanding is you're quite technical. :slightly_smiling_face:
UjjwalAhluwalia Yes I had contributed patches and fixes at technical side. I love to work more at technical side.
ijf8090 I have an interest in working on the code. have not coded since D6 looking to get back into it. How hard can that be? It's not like there have been many significant changes, right? :slightly_smiling_face: Interested in back end rather than front end
leslieg Lots of changes, but good to see you hopping back into the code.  I’ll let @chrisfromredfin know you are available to help

Several accessibility issues were spotted by @narendraR but they don't have individual issues, so there are tasks for1) filing those issues - see comment 2 #3282265: Conduct an Accessibility review of the module (Late May 2022)#comment-145385492) working on those newly filed issues

hj (they/them) I can start filing these
hj (they/them) Issues are filed and marked it the review issue as fixed

@Jillian Chueka @Divya Mangadu @saschaeggi - any input? #3282589: No way to return to Default filters

Divya Mangadu Yes, I did have a question first - the pills were for the "advanced filtering". Since that isn't being included in this round, I don't think those would be included at all, correct?
Divya Mangadu My thought is that we wouldn't need an "uncheck all/reset all" for the categories since users will probably only click a couple at a time. If the advanced filtering was being built, then I'd say a "reset" button would be helpful
chrisfromredfin Someone just kinda "did it" so I think we are doing advanced filtering; it's already in the codebase :stuck_out_tongue:
chrisfromredfin So I'm thinking a link for "Reset to defaults" (or "Reset to recommended" and another "Clear all filters" ??
Divya Mangadu Does the default set look visually different from showing all the modules? I'd suggest just having "clear all filters". Having both is most likely going to be confusing/unclear and I'm wondering either  if1) "recommended" could be a filter itself or 2)  recommended modules could be surfaced to the top when all modules are shown automatically

Also for the crew above - #3267678: Use icon to assist with understanding of maintenance status#comment-14538955

drumm The design on project pages on Drupal.org is explicitly to not show that, since “actively maintained” is often not accurate. It tends to be forgotten. The other statuses, are more accurate and useful. So we just call out the negative statuses, and don’t clutter with the maybe-positive-but-maybe-not one.

3️⃣  Project Short Description Discussions

bsnodgrass (he/him) @leslieg I'm feeling less than effective this morning... too many interruptions. I am going to break away for a bit to take care of them... Threading so people can follow.
run fast think slow This is a good idea. maybe thread for Categories and logo? or put everything here???
bsnodgrass (he/him) @run fast think slow maybe a separate thread for each (edited)
leslieg yes, good idea - just created them
bsnodgrass (he/him) Currently the short description is trimmed text from the project. Is that the plan for now?
leslieg Reminder to keep the short descriptions to 200 characters or less
bsnodgrass (he/him) that was my next question you beat me to it
bsnodgrass (he/him) I'm thinking comment or working on the child issues directly is the most effective.
run fast think slow There is a column in the spreadsheet that will count the characters for you. very helpful
leslieg I will check old tickets to make sure that is specified @bsnodgrass (he/him) We just got confirmation that 200 will work with the designs
bsnodgrass (he/him) I flagged a few short description issues back to needs work. Reviewing others marked active before I head out for errands.
chrisfromredfin I'd like to hop in to some descriptions. are we using assignment or anything? How would I know which one to look at? Can I just pick any?
run fast think slow I noticed Bob added a comment in the spreadsheet for 1 row he was working on at the top ....
bsnodgrass (he/him) Those looking for short descriptions that need workhttps://www.drupal.org/project/issues/project_browser?text=add+a+short+d...
bsnodgrass (he/him) Those looking for Short Descriptions that Need Review (ignore the meetings)https://www.drupal.org/project/issues/project_browser?text=add+a+short+d... (edited)
bsnodgrass (he/him) All the child issues needing Short Descriptions are now marked "needs work" or "needs review"back in about 90 minutes
chrisfromredfin if I propose text (as I have for Metatag and Simple XML Sitemap), should I mark as Needs Review?
leslieg yes @chrisfromredfin
chrisfromredfin k
chrisfromredfin If we want to tag them also, we could do contribkanban for these. Just in case that's helpful.
leslieg There’s a lot of good info in the “top 100” google doc. I started to color code the child issues as green if done on d.o and yellow if has proposed and needs review (edited)
bsnodgrass (he/him) Back to reviewing... does this look reasonable to move these forward? #3282620: Simple XML sitemap Project - Add a short description#comment-14539342
bsnodgrass (he/him) Hearing no objections I will continue with that process.
leslieg Please assign RTBC tickets to leslieg. I will add ticket in module issue queue
bsnodgrass (he/him) Will do, ...  I should say, I tried, but I don't seem able to assign these to anyone but myselfInstead Find Short Description RTBC with https://www.drupal.org/project/issues/project_browser?text=add+a+short+d... (edited)
bsnodgrass (he/him) Screen Shot 2022-05-27 at 4.00.45 PM.png
chrisfromredfin Yes unfortunately assignment is maintainer to maintainer, or if not a maintainer, self or no one. NR is really our best indicator.
leslieg That’s right. I need to do that. Sorry for bad instruction
bsnodgrass (he/him) I will be able to work on Short descriptions for a bit this morning. I will keep them set to Needs Review rather than RTBC... unless someone tells me differently
leslieg Good morning @bsnodgrass (he/him) Yes, put them in “Needs Review” if you work on proposing a description. If you review someone else’s ticket, you can move them to RTBC. Ping me on the ticket and I’ll reassign them to myself.
leslieg @bsnodgrass (he/him) What do you think about the use of the Project name in the start of the short description. We should be consistent with this. Example - is Scheduler needed in this? “Scheduler gives content editors the ability to schedule nodes to be published and unpublished at specified dates and times in the future.”
leslieg Personally I don’t think the project name should be included, but interested in other’s thoughts. cc @chrisfromredfin (edited)
chrisfromredfin No we have minimal space so repeating the title that will be right above it (both in pb and on d.o) is a waste
leslieg agree - some folks were doing it so I thought I’d ask. I’ll add a note to the instructions to not do that and will update the tickets in Needs Review that have the project name in them. Thanks
bsnodgrass (he/him) @leslieg @chrisfromredfin I agree, the module name is NOT ideal for the short description.Are we are recommending the short description be incorporated at the beginning of the project description?
bsnodgrass (he/him) As we move forward, I think it would be easiest to be pulling a new field (or making the Summary required and different for this use as well as the Metatag Description) from the project description rather than have it be part of the original description. My reasoning being:Maintainers of existing will NOT have to edit their project description and it will be clear for new projects  Many projects have old descriptions for Drupal 7 in the beginning, with Drupal 8/9 following, making some of this editing a heavy liftFor new projects this could be made clear and allow the community to keep consistency(edited)
leslieg Yes add the the start of the project description and also to the Summary field. We’ll be pulling the short description from the summary
bsnodgrass (he/him) I know I am coming back to the party late, not to throw a wrench into discussions I've missed, but the more I think about adoption and long term maintenance, we should consider this.
leslieg Thanks for thinking about the impact on maintainers. We are concentrating on just what will be displayed in the project browser at this point (the logo, short description and categories), but do have tickets for updates to the project pages in a later phase.  Ideas like recommending a template to make project pages more consistent, etc.  We wIll be interested in your and other’s thoughts on that. @bsnodgrass (he/him)
leslieg For now we could just suggest adding the short description to the summary field
bsnodgrass (he/him) I think that might work... and be an easy lift. Do we have a maintainer who could try that out and give us feedback?
bsnodgrass (he/him) BTW, #3282620: Simple XML sitemap Project - Add a short description keeping it set as RTBC
leslieg I’ll ask @nerdstein He expressed an interest in updating the projects that he maintains.
chrisfromredfin Summary field is best for now I strongly believe
bsnodgrass (he/him) #3282602: Chaos Tools Project - Add a short description is ready and still marked RTBC
bsnodgrass (he/him) #3277513: Admin Toolbar Project - Add a short description is ready and still marked RTBC
bsnodgrass (he/him) FYI @leslieg #3277522: Metatag Project - add a short description#comment-14539703. - I assigned this to myself to ask Damien about it next Thursday (edited)
bsnodgrass (he/him) @leslieg I will go ahead and assign the Meta Issue for Metatag and child issues as well. I can ask him about all of them at the same time. Can we plan on talking before next Thursday so I am clear on all the planning? or would you also like to join us at https://www.drupal.org/project/contrib_half_hour?
leslieg @bsnodgrass (he/him) I added the meeting to my calendar - need to see if I can move another meeting happening at the same time.  Does Wednesday morning work for you and I to meet. During the PB time or right after?
bsnodgrass (he/him) perfect

4️⃣  Project Logo Discussion

run fast think slow Working on this late - is the sprint over ---According to the instructions it says to "Create a logo that is 512x512 square dimension in PNG format without animations." but if the logo already exists and want to use that as in the case for https://www.drupal.org/project/twig_tweak I am going to say make sure is within the bounds, file size, and anything smaller than 512 x 512 is ok.  But checking.I am going to focus on logos vs the descriptions for the rest.  Let someone else do that!
run fast think slow The file size dropped by quite a bit, but don't want to change the image size or do we want at least 1 border to come to the edge (512 pixels)?
run fast think slow @leslieg See above questions.Or are the instructions intended for new logo creation?

It would be good to land #3282499: Translate strings in Svelte app as it's kind of a beast to rebase as it touches so many files. It also makes some of the Svelte code easier to deal with :slightly_smiling_face:

chrisfromredfin I'm putting on my @timplunkett (he/him) hat here :billed_cap: but - was refactoring FilterApplied and FilterGroup necessary for translation? I'm more of the "yeah that's still a great idea, ship it" mentality but I know Tim might yell at me if someone is in that wasn't directly related to the issue.
chrisfromredfin :rolling_on_the_floor_laughing:
bnjmnm It's definitely a loose interpretation of  being in scope... I found myself doing the exact same translations/a11y fixes in multiple places and it was getting really confusing.
chrisfromredfin ok so you refactored it to make that work easier? that's in scope if you ask ME :wink:
chrisfromredfin ok @bnjmnm and what was this fixing?
chrisfromredfin (^ put comment on actual MR)
bnjmnm Ah crap, that one is arguably out of scope. It ensures the logos and download buttons are at the bottom of each card
chrisfromredfin ok that's the only thing I found. I'd say roll that out and make sure it's mergeable.
timplunkett (he/him) I'm reviewing now
timplunkett (he/him) if you want to wait just in case I notice omething
bnjmnm NP
chrisfromredfin k. that's all I had, so ship it @timplunkett (he/him) if you like it
chrisfromredfin Also "Soorch foor moodools" gave me a laugh in the test.
chrisfromredfin so thank you
timplunkett (he/him) 3 nits, @bnjmnm
timplunkett (he/him) for the record, i'm fine with the newly added @todo s
timplunkett (he/him) merging now
chrisfromredfin oh yeah same with the todo's, they're just comments and important. as a matter of course if you notice stuff, I generally say "yeah, fine" tho I wish moreso they were @todo - link to issue already filed :wink:
timplunkett (he/him) yes that's def preferred but didn't want to hold up due to the intensive rebase potential

^ Yeah, passed on re-run. I think we need more of a known state. Will file an issue.

timplunkett (he/him) This is why I wanted a non-random fixture for tests. We need to just remove the random plugin altogether
timplunkett (he/him) I tried to push back before but now it's clear
chrisfromredfin Yeah seems like RandomData is good to prove decoupling and demo, but is not a reliable test instance.
chrisfromredfin #3282778: Unreliable test: testBrokenImages()
fjgarlin Both can live there in my opinion. I can make it force the fail but we defo need a non-mock-non-DB plugin to test things out, specially decoupling. RandomData is now a submodule in any case. I assigned the issue to me.  (edited)
fjgarlin Was generating at least 12 items and rand 0-3 seemed good enough but I'll make sure there is ALWAYS a failure for that plugin and test.
fjgarlin #3282778: Unreliable test: testBrokenImages()#comment-14539621 Needs review
chrisfromredfin Thanks, merged!

Anybody want to get into linux Operating support support issue?  It's for project browser related....

chrisfromredfin I'm decent with that stuff, but I have to stay in chat cuz I'm up with kids
run fast think slow Thank you Chris for the help!

Participants:

volkswagenchick, bsnodgrass, leslieg, pearcraft, chrisfromredfin, ijf8090, hildog, zebruh_divs, drumm, bnjmnm, tim.plunkett, fjgarlin, UjjwalAhluwalia, run fast think slow -lets4-

Comments

leslieg created an issue. See original summary.

leslieg credited bnjmnm.

leslieg credited bsnodgrass.

leslieg credited chrisfromredfin.

leslieg credited drumm.

leslieg credited fjgarlin.

leslieg credited hildog.

leslieg credited ijf8090.

leslieg credited pearcraft.

leslieg credited run fast think slow -lets4-.

leslieg credited tim.plunkett.

leslieg credited ujjwalahluwalia.

leslieg credited volkswagenchick.

leslieg credited zebruh_divs.

leslieg’s picture

leslieg commented
leslieg’s picture

leslieg commented
Status: Active » Fixed
leslieg’s picture

leslieg commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.