| timplunkett (he/him) |
Happy to join, let me know. Srishti just RTBC'd it |
| chrisfromredfin |
oh amazing, so good to get eyes on it |
| timplunkett (he/him) |
(I would like to review before commit, and it's assigned to me) |
| chrisfromredfin |
I will def leave it assigned to you but I'm going to take a swipe |
| timplunkett (he/him) |
the more the merrier :smile: |
| fjgarlin |
I can meet (zoom?) from now now until my 17:00 (in 38m) and I can run you through all the changes, screenshare, etc (edited) |
| fjgarlin |
I assigned it to you (Tim) to be on the safe side and have a final check. |
| fjgarlin |
alternatively, I could meet after my 19:30 (10:30PDT?) (edited) |
| timplunkett (he/him) |
that's 3hr from now? would work better for me |
| chrisfromredfin |
I think I could do what is my (and Tim's) afternoon, about 3hr from now? |
| fjgarlin |
yup. 3h from now, correct. I’m happy either way. |
| timplunkett (he/him) |
(we're both EDT) (edited) |
| fjgarlin |
oh, I thought you guys were PDT :upside_down_face:In any case. 3h from now worksif you paste here your email address I can create the event with the zoom linkanybody that puts their email will be added to the event |
| timplunkett (he/him) |
tim.plunkett@acquia.com |
| chrisfromredfin |
chris@redfinsolutions.com |
| fjgarlin |
invite sent = :white_check_mark: (edited) |
| bsnodgrass (he/him) |
bsnodgrass@net2community.com |
| run fast think slow |
@fjgarlin ok to send you a DM with email? (edited) |
| fjgarlin |
Yup. No problem |
| fjgarlin |
meeting starting now. if you have any issues joining just let me know |
| fjgarlin |
are y’all using meets or zoom link? I didn’t even realise there was a meets one. I’m in zoom |
| timplunkett (he/him) |
we're in the meet link |
| fjgarlin |
:facepalm: |
| timplunkett (he/him) |
coming to zoom |
| chrisfromredfin |
Will join zoom |
| fjgarlin |
sorry and thanks :slightly_smiling_face: |
| timplunkett (he/him) |
@bsnodgrass (he/him) https://us04web.zoom.us/j/75805679705?pwd=fo-CKDDdLUK_0GOjDALmLRTx3sw4pC.1 |
| bsnodgrass (he/him) |
waiting for host BTW |
| timplunkett (he/him) |
https://acquia.zoom.us/my/timplunkett |
| chrisfromredfin |
^ this url may ask you for room name, which is just 'timplunkett' |
| bnjmnm |
Hopefully the increased vigilance of DrupalCI won't be too discouraging, and it will ensure the code formatting is core-ready |
| chrisfromredfin |
My goal/plan was to actually have the MR tests fail(GitLabCI) on code standards. I'm wondering if I should continue bothering with that or if we just want it in the build process forever, and simplify the CI (it's good for now regardless since GitLab CI is not ready) |
| chrisfromredfin |
I am going to look at the yarn one first, as that's likely less disruptive |
| chrisfromredfin |
HA, so something to consider here is now with .gitattributes it seems bundle.css is a binary, so it won't diff it. |
| chrisfromredfin |
must be a way to override that |
| chrisfromredfin |
ahh yes, --text |
| chrisfromredfin |
I've [taken to twitter](https://twitter.com/chrisfromredfin/status/1526938633273581574?s=20&t=UY...) to see if we can get an answer about the build inconsistencies from Rich or someone. |
| chrisfromredfin |
I may try Stack Overflow next. Do we want to split this into its own issue and leave this one as just "switch to Yarn" ? |
| bnjmnm |
+1 on splitting the issues |
| chrisfromredfin |
ok will do. |
| bnjmnm |
I may have misphrased regarding ESlint, its leveraging DrupalCI . Standard Svelte lint + Drupal JS standards are enforced. I'm now working on integrating prettier, which could potentially check HTML and CSS indentation within the .svelte files as well. I think it's feasible but I'll timebox it as it's already a big win to have the JS in the .svelte files linted. |
| chrisfromredfin |
Oh i see - so it's not failing the build process on linter errors, it's failing in tests oin DrupalCI? |
| chrisfromredfin |
Oh also - |
| chrisfromredfin |
would we still want to allow an npm run build ^^ or should we also prevent that with Yarn? |
| chrisfromredfin |
ultimately both are running rollup |
| chrisfromredfin |
so I think it probably doesn't matter? (edited) |
| bnjmnm |
I want to prevent npm run build as well. |
| bnjmnm |
Shouldn't be difficult, I just didn't think to do that when I was last working on it |
| chrisfromredfin |
ok I'll split it and mark back to NR |
| chrisfromredfin |
NW i mean |
| chrisfromredfin |
k that's all done |
| Gábor Hojtsy (he/him) |
I think @leslieg was planning to reach out to one of them :slightly_smiling_face: |
| Gábor Hojtsy (he/him) |
Would be great to feature the project there and get some more exposure, especially since we don’t have a DrupalCon video to shop around |
| chrisfromredfin |
Oh last I heard YOU were going to reach out to people @Gábor Hojtsy (he/him) - I have been on Talking Drupal a bunch, but if there are others, I love to do podcast things. |
| Gábor Hojtsy (he/him) |
This was the last discussion 2 weeks ago :slightly_smiling_face: https://drupal.slack.com/archives/C01UHB4QG12/p1651675944683839?thread_t... |
| chrisfromredfin |
https://www.talkingdrupal.com/305 |
| Gábor Hojtsy (he/him) |
That's been 8 months! I think a lot has changed? :) Especially with the recent Driesnote? :) |
| leslieg |
Talking Drupal is interested in doing another podcast. Working with them on a date @Gábor Hojtsy (he/him) |
| Gábor Hojtsy (he/him) |
Amazing! Claro+Olivero will also be on talking Drupal in 3 weeks or so :) |
| chrisfromredfin |
yes I saw Mike in the channel bringing Christina on as his guest |
| chrisfromredfin |
I did just guest host Talking Drupal for the last month so they MAY want maybe Leslie & Gábor or we could get Tim to do it |
| chrisfromredfin |
Tim P |
| Gábor Hojtsy (he/him) |
@timplunkett (he/him) could be more appropriate yeah :) |
| Gábor Hojtsy (he/him) |
(as opposed to me) |
| leslieg |
@timplunkett (he/him) Talking Drupal has availability on July 26th to have a podcast on the Project Browser initiative. I will be on from the Initiative Lead/Sitebuilder Subcommittee side, would you be able to join to represent the technical side? @chrisfromredfin has been a guest host for the last month, so they prefer to have someone else on this podcast. |
| timplunkett (he/him) |
Sure, I'd be happy to. I don't think I've been on Talking Drupal before |
| Gábor Hojtsy (he/him) |
@leslieg @timplunkett (he/him) is this scheduled for July 26th then? :slightly_smiling_face: curious :slightly_smiling_face: (edited) |
| leslieg |
yes Talking Drupal episode is scheduled for July 26th @Gábor Hojtsy (he/him) |
| Gábor Hojtsy (he/him) |
great, thanks |
timplunkett (he/him), chrisfromredfin, fjgarlin, bsnodgrass (he/him), run fast think slow, bnjmnm, Gábor Hojtsy, leslieg
Comments
Comment #8
leslieg commentedComment #10
leslieg commentedComment #11
leslieg commented